From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Hirokazu Takahashi <taka@valinux.co.jp>
Cc: netdev@vger.kernel.org, kaber@trash.net, davem@davemloft.net,
linux-net@vger.kernel.org
Subject: Re: [PATCH] tbf scheduler: TSO support (updated)
Date: Sun, 13 May 2007 08:52:48 -0700 [thread overview]
Message-ID: <20070513085248.283bf060@mini> (raw)
In-Reply-To: <20070513.214236.130588832.taka@valinux.co.jp>
On Sun, 13 May 2007 21:42:36 +0900 (JST)
Hirokazu Takahashi <taka@valinux.co.jp> wrote:
> Hi,
>
> > I'm now thinking I can make it just hold a TSO packet until
> > p->tokens reaches the size of the packet. I think it is
> > straightforward implementation. I'll try this.
>
> I re-implemented the patch, which is simpler than the previous one.
>
> sch->dev->mtu is used to determine how many segments are included
> in a TSO packet. The point is that the value of sch->dev->mtu has to
> be treated possibly broken because it is set by administrators.
>
There are cases where the TSO packet will be divided into chunks
smaller than the MTU. If path MTU discovery is being used, the chunk
size of the TSO skb will be smaller. To be accurate you need to look
at mss (gso_size) and compute actual packet size based on protocol
(IPV4/IPV6 and UDP/TCP).
next prev parent reply other threads:[~2007-05-13 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070510.210556.05145104.taka@valinux.co.jp>
2007-05-10 12:56 ` [PATCH] tbf scheduler: TSO support Patrick McHardy
2007-05-10 21:13 ` David Miller
2007-05-11 1:04 ` Patrick McHardy
2007-05-11 4:01 ` Hirokazu Takahashi
2007-05-11 18:13 ` Patrick McHardy
2007-05-12 8:49 ` Hirokazu Takahashi
2007-05-12 9:09 ` Hirokazu Takahashi
2007-05-13 12:42 ` [PATCH] tbf scheduler: TSO support (updated) Hirokazu Takahashi
2007-05-13 15:52 ` Stephen Hemminger [this message]
2007-05-13 16:21 ` Hirokazu Takahashi
2007-05-14 6:04 ` Herbert Xu
2007-05-15 11:39 ` [PATCH 1/2] tbf scheduler: TSO support (update 2) Hirokazu Takahashi
2007-05-15 11:41 ` [PATCH 2/2] " Hirokazu Takahashi
2007-05-17 13:55 ` Herbert Xu
2007-05-18 2:35 ` Hirokazu Takahashi
2007-05-23 11:47 ` [PATCH 1/2] tbf scheduler: TSO support (update 3) Hirokazu Takahashi
2007-05-23 11:49 ` [PATCH 2/2] " Hirokazu Takahashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513085248.283bf060@mini \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).