From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS Date: Wed, 16 May 2007 08:13:01 +0100 Message-ID: <20070516071300.GB14222@infradead.org> References: <464034CF.20700@wpkg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org, Michael Jones , Krzysztof Halasa To: Tomasz Chmielewski Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:44239 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbXEPHNC (ORCPT ); Wed, 16 May 2007 03:13:02 -0400 Content-Disposition: inline In-Reply-To: <464034CF.20700@wpkg.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, May 08, 2007 at 10:29:03AM +0200, Tomasz Chmielewski wrote: > Michael Jones wrote: > > >>+#ifndef __ARMEB__ > >>+#warning Little endian mode not supported > >>+#endif > > > >Personally I'm less fussed about WAN / LE support. Anyone with any > >sense will run ixp4xx boards doing such a specialised network > >operation as BE. Also, NSLU2-Linux can't test this functionality with > >our LE setup as we don't have this hardware on-board. You may just > >want to declare a depends on ARMEB in Kconfig (with or without OR > >(ARM || BROKEN) ) and have done with it - it's up to you. > > Christian Hohnstaedt's work did support LE though. > > Not all ixp4xx boards are by definition "doing such a specialised > network operation". > > > Krzysztof, why is LE not supported? > > Do you need access to ixp4xx that starts in LE mode? Not even trying to support LE is a clear merge blocker. Maybe Krzysztof can't actually test it himself, which is fine - but not even pretending to be endian clean is not what proper Linux drivers do.