From: Christoph Hellwig <hch@infradead.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Auke Kok <auke-jan.h.kok@intel.com>,
jeff@garzik.org, wenxiong@us.ibm.com
Subject: Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW
Date: Thu, 17 May 2007 10:01:19 +0100 [thread overview]
Message-ID: <20070517090119.GA27145@infradead.org> (raw)
In-Reply-To: <495A2DE1-775D-4DFC-9C1C-4644AA5A040B@kernel.crashing.org>
On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote:
> >index 49be393..830d851 100644
> >--- a/drivers/net/e1000/e1000_main.c
> >+++ b/drivers/net/e1000/e1000_main.c
> >@@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)
> > E1000_WRITE_REG(&adapter->hw, CTRL, ctrl);
> > }
> >
> >+#if defined(CONFIG_PPC64) || defined(CONFIG_PPC)
>
> If this is really on need on pseries HW this should be #ifdef
> CONFIG_PPC_PSERIES. No reason to force this on all PPC.
No, it shouldn't. powerpc kernels are multi-platform.
It really shouldn't be there at all because something in either the intel
or pseries hardware is totally buggy and we should disable features in
the buggy one completely.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-17 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 8:53 [PATCH] e1000: Work around 82571 completion timout on Pseries HW Auke Kok
2007-05-16 16:00 ` Jeff Garzik
2007-05-16 22:11 ` Wen Xiong
2007-05-16 22:31 ` Benjamin Herrenschmidt
2007-05-17 0:43 ` Kumar Gala
2007-05-17 9:01 ` Christoph Hellwig [this message]
2007-05-17 13:10 ` Kumar Gala
2007-05-17 14:58 ` Wen Xiong
2007-05-17 21:04 ` Jeff Garzik
2007-05-17 21:44 ` wendy xiong
2007-06-23 8:20 ` Christoph Hellwig
2007-06-23 17:05 ` Kok, Auke
2007-05-18 0:47 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517090119.GA27145@infradead.org \
--to=hch@infradead.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).