From: David Miller <davem@davemloft.net>
To: eteo@redhat.com
Cc: netdev@vger.kernel.org, acme@redhat.com, randy.dunlap@oracle.com
Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
Date: Fri, 18 May 2007 23:03:53 -0700 (PDT) [thread overview]
Message-ID: <20070518.230353.71553281.davem@davemloft.net> (raw)
In-Reply-To: <464E8FD7.9030203@redhat.com>
From: Eugene Teo <eteo@redhat.com>
Date: Sat, 19 May 2007 13:49:11 +0800
> Spotted by the Coverity checker.
Why am I not surprised :-(
There is no bug here, if Coverity warns every single time skb_peek()
is used and not tested against NULL, that's a very serious shortcoming
of Coverity or what it has been taught about SKB queues.
It needs to learn that skb_queue_len() != 0 implies skb_peek() will
not return NULL sans locking errors.
prev parent reply other threads:[~2007-05-19 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <464E8763.3010609@redhat.com>
2007-05-19 5:43 ` [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference Herbert Xu
[not found] ` <20070518223005.91236c38.randy.dunlap@oracle.com>
2007-05-19 5:49 ` Eugene Teo
2007-05-19 6:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518.230353.71553281.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=eteo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).