From: Stephen Hemminger <shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: Florin Malita <fmalita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linville-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] libertas: skb dereferenced after netif_rx
Date: Fri, 18 May 2007 22:23:08 -0700 [thread overview]
Message-ID: <20070518222308.11c2b34d@localhost> (raw)
In-Reply-To: <20070518180903.GC3492-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
On Fri, 18 May 2007 14:09:03 -0400
"John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> wrote:
> On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
> > In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
> > skb is dereferenced after being passed to netif_rx (called from
> > libertas_upload_rx_packet). Spotted by Coverity (1658, 1659).
>
> Relocating the libertas_upload_rx_packet call is fine, but...
>
> > Also, libertas_upload_rx_packet() unconditionally returns 0 so the error
> > check is dead code - might as well take it out.
>
> Is this merely an implementation detail? Or an absolute fact?
> If the former is true, then we should preserve the error
> checking. If the latter, then we should change the signature of
> libertas_upload_rx_packet to return void.
netif_rx() used to return a value in older kernels.
next prev parent reply other threads:[~2007-05-19 5:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 21:01 [PATCH] libertas: skb dereferenced after netif_rx Florin Malita
[not found] ` <464B7127.5080502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-05-18 18:09 ` John W. Linville
[not found] ` <20070518180903.GC3492-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-05-18 20:04 ` Florin Malita
2007-05-19 5:23 ` Stephen Hemminger [this message]
2007-05-19 5:37 ` Jeff Garzik
2007-05-20 0:56 ` Dan Williams
2007-05-20 1:47 ` Jeff Garzik
[not found] ` <464FA894.8090008-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
2007-05-20 5:20 ` Stephen Hemminger
2007-05-20 6:36 ` Jeff Garzik
2007-05-20 7:38 ` David Miller
[not found] ` <20070520.003832.59470116.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-05-21 14:51 ` Florin Malita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518222308.11c2b34d@localhost \
--to=shemminger-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=fmalita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=linville-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).