From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Sangtae Ha <sangtae.ha@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Sangtae Ha <sangtae.ha@gmail.com>
Subject: Re: [PATCH] [TCP] tcp_probe: a trivial fix for mismatched number of printl arguments.
Date: Mon, 21 May 2007 09:00:53 -0700 [thread overview]
Message-ID: <20070521090053.72d98316@freepuppy> (raw)
In-Reply-To: <11797335421143-git-send-email-sangtae.ha@gmail.com>
On Mon, 21 May 2007 03:45:42 -0400
Sangtae Ha <sangtae.ha@gmail.com> wrote:
> Just a fix to correct the number of printl arguments. Now, srtt is logging correctly.
>
> Signed-off-by: Sangtae Ha <sangtae.ha@gmail.com>
> ---
> net/ipv4/tcp_probe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
> index 3938d5d..1b72c55 100644
> --- a/net/ipv4/tcp_probe.c
> +++ b/net/ipv4/tcp_probe.c
> @@ -95,7 +95,7 @@ static int jtcp_rcv_established(struct sock *sk, struct sk_buff *skb,
> /* Only update if port matches */
> if ((port == 0 || ntohs(inet->dport) == port || ntohs(inet->sport) == port)
> && (full || tp->snd_cwnd != tcpw.lastcwnd)) {
> - printl("%d.%d.%d.%d:%u %d.%d.%d.%d:%u %d %#x %#x %u %u %u\n",
> + printl("%d.%d.%d.%d:%u %d.%d.%d.%d:%u %d %#x %#x %u %u %u %u\n",
> NIPQUAD(inet->saddr), ntohs(inet->sport),
> NIPQUAD(inet->daddr), ntohs(inet->dport),
> skb->len, tp->snd_nxt, tp->snd_una,
Looks good thanks
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-21 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 7:45 [PATCH] [TCP] tcp_probe: a trivial fix for mismatched number of printl arguments Sangtae Ha
2007-05-21 16:00 ` Stephen Hemminger [this message]
2007-05-21 16:02 ` [PATCH] tcp_probe: use GCC printf attribute Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521090053.72d98316@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sangtae.ha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox