From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Kieran Mansley <kmansley@solarflare.com>
Cc: xen-devel@lists.xensource.com, netdev@vger.kernel.org,
muli@il.ibm.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules
Date: Mon, 21 May 2007 10:52:58 -0700 [thread overview]
Message-ID: <20070521105258.7988fd6e@freepuppy> (raw)
In-Reply-To: <1179494208.14376.10.camel@moonstone.uk.level5networks.com>
On Fri, 18 May 2007 14:16:48 +0100
Kieran Mansley <kmansley@solarflare.com> wrote:
> Add support to Xen netfront for accelerated plugin module
>
>
>
> +/*
> + * List of all netfront accelerator plugin modules available. Each
> + * list entry is of type struct netfront_accelerator.
> + */
> +static struct list_head accelerators_list;
> +/*
> + * Lock to protect access to accelerators_list, and also used to
> + * protect the hooks_usecount field in struct netfront_accelerator
> + * against concurrent access
> + */
> +static spinlock_t accelerators_lock;
> +
Your locking model is more complex than it needs to be.
If you just used RCU for access, and depended on the existing RT netlink
mutex (a.k.a big network lock), for setup; then you wouldn't need to
do any of your own locking.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-21 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 13:16 [PATCH 3/4] [Net] Support Xen accelerated network plugin modules Kieran Mansley
2007-05-21 17:50 ` Stephen Hemminger
2007-05-22 7:00 ` Kieran Mansley
2007-05-21 17:52 ` Stephen Hemminger [this message]
2007-05-22 7:15 ` Kieran Mansley
2007-05-22 7:28 ` Kieran Mansley
2007-05-22 7:48 ` [Xen-devel] " Keir Fraser
2007-05-22 7:59 ` Kieran Mansley
2007-05-22 12:44 ` Kieran Mansley
2007-05-22 14:07 ` Keir Fraser
2007-05-22 14:20 ` Kieran Mansley
2007-05-22 15:05 ` Stephen Hemminger
2007-05-22 16:06 ` Kieran Mansley
2007-05-25 6:53 ` Andi Kleen
2007-05-21 17:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521105258.7988fd6e@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kmansley@solarflare.com \
--cc=muli@il.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).