From: Dave Jones <davej@redhat.com>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: herbert@gondor.apana.org.au, jeff@garzik.org,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
greg@suse.de, stable@vger.kernel.org
Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)
Date: Mon, 21 May 2007 18:16:35 -0400 [thread overview]
Message-ID: <20070521221635.GA16888@redhat.com> (raw)
In-Reply-To: <20070521215134.14885.84952.stgit@localhost.localdomain>
On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote:
> Herbert Xu wrote:
> "netif_poll_enable can only be called if you've previously called
> netif_poll_disable. Otherwise a poll might already be in action
> and you may get a crash like this."
>
> Removing the call to netif_poll_enable in e1000_open should fix this issue,
> the only other call to netif_poll_enable is in e1000_up() which is only
> reached after a device reset or resume.
>
> Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339
This probably doesn't solve the latter bug.
The code you reference isn't there in the kernel tested in that bug
(2.6.21) In 2.6.21, netif_poll_enable is only called from
e1000_up(), not e1000_open()
Dave
--
http://www.codemonkey.org.uk
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-21 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 21:51 [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1) Auke Kok
2007-05-21 22:16 ` Dave Jones [this message]
2007-05-22 0:49 ` Herbert Xu
2007-05-22 0:58 ` Kok, Auke
2007-05-22 1:22 ` Dave Jones
2007-05-21 23:42 ` Jeff Garzik
2007-05-22 0:04 ` Kok, Auke
2007-05-22 1:01 ` Herbert Xu
2007-05-22 16:56 ` Chuck Ebbert
2007-05-22 17:02 ` Kok, Auke
2007-05-23 10:47 ` Herbert Xu
2007-05-23 23:34 ` Chris Wright
2007-05-23 23:38 ` Kok, Auke
2007-05-24 1:29 ` Herbert Xu
2007-05-24 4:31 ` Chris Wright
2007-05-24 1:29 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2007-05-21 15:32 Auke Kok
2007-05-21 21:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521221635.GA16888@redhat.com \
--to=davej@redhat.com \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greg@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).