From: David Miller <davem@davemloft.net>
To: vvs@sw.ru
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org, akpm@osdl.org,
linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH netdev] "wrong timeout value" in sk_wait_data() v2
Date: Thu, 24 May 2007 16:59:47 -0700 (PDT) [thread overview]
Message-ID: <20070524.165947.09931811.davem@davemloft.net> (raw)
In-Reply-To: <46552142.4090801@sw.ru>
From: Vasily Averin <vvs@sw.ru>
Date: Thu, 24 May 2007 09:23:14 +0400
> sys_setsockopt() do not check properly timeout values for
> SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout
> values. POSIX do not defines behaviour for sys_setsockopt in case negative
> timeouts, but requires that setsockopt() shall fail with -EDOM if the send and
> receive timeout values are too big to fit into the timeout fields in the socket
> structure.
> In current implementation negative timeout can lead to error messages like
> "schedule_timeout: wrong timeout value".
>
> Proposed patch:
> - checks tv_usec and returns -EDOM if it is wrong
> - do not allows to set negative timeout values (sets 0 instead) and outputs
> ratelimited information message about such attempts.
>
> Signed-Off-By: Vasily Averin <vvs@sw.ru>
Thank you for this bug fix, patch applied.
prev parent reply other threads:[~2007-05-24 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 4:22 [PATCH netdev] "wrong timeout value" in sk_wait_data() Vasily Averin
2007-05-24 4:36 ` Eric Dumazet
2007-05-24 5:23 ` [PATCH netdev] "wrong timeout value" in sk_wait_data() v2 Vasily Averin
2007-05-24 23:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524.165947.09931811.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=dada1@cosmosbay.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).