From: linas@austin.ibm.com (Linas Vepstas)
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org,
Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>,
Sivakumar Subramani <sivakumar.subramani@neterion.com>,
Sreenivasa Honnur <sreenivasa.honnur@neterion.com>,
Rastapur Santosh <santosh.rastapur@neterion.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH] s2io: don't run MSI handlers if device is offline.
Date: Fri, 25 May 2007 13:29:29 -0500 [thread overview]
Message-ID: <20070525182929.GB4323@austin.ibm.com> (raw)
In-Reply-To: <46560198.9080204@pobox.com>
On Thu, May 24, 2007 at 05:20:24PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >Don't run any of the MSI handlers if the channel is off;
> >also don't gather device statatistics. Also, netif_wake
> >not needed, per suggestions from
> >Sivakumar Subramani <sivakumar.subramani@neterion.com>.
> >
> Why are the interrupt handlers being called at all, then?
>
> This seems to be papering over another bug.
Ahh ... are you suggesting that the arch should be performing
this check in driver-independent code, and not delivering the
MSI if the pci channel is deemed offline? Yes, right, good point.
So far, I'd hadn't really given this much thought, and had been
letting the dev drivers perform this check, but, yes, it is probably
better to have one common check performed in the generic arch-specific
code, and the interrupt dropped, if the device is offlined.
I'll look into this.
--linas
prev parent reply other threads:[~2007-05-25 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 22:50 [PATCH] s2io: don't run MSI handlers if device is offline Linas Vepstas
2007-05-23 5:03 ` Sivakumar Subramani
2007-05-24 21:20 ` Jeff Garzik
2007-05-25 18:29 ` Linas Vepstas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525182929.GB4323@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).