From: Michael Buesch <mb@bu3sch.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jeff Garzik <jgarzik@pobox.com>,
Gary Zambrano <zambrano@broadcom.com>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Uwe Bugla <uwe.bugla@gmx.de>,
Maximilian Engelhardt <maxi@daemonizer.de>
Subject: Re: b44: regression in 2.6.22
Date: Sat, 26 May 2007 19:01:17 +0200 [thread overview]
Message-ID: <200705261901.18110.mb@bu3sch.de> (raw)
In-Reply-To: <20070525172431.60affaca@freepuppy>
On Saturday 26 May 2007 02:24:31 Stephen Hemminger wrote:
> Something is broken with the b44 driver in 2.6.22-rc1 or later. Now bisecting.
> The performance (with iperf) for receiving is normally 94Mbits or more.
> But something happened that dropped performance to less than 1Mbit,
> probably corrupted packets.
>
> There is nothing obvious in the commit log for drivers/net/b44.c, so it
> probably is something more general.
>
>
> Looking at the code in b44_rx(), I see a couple unrelated of bugs:
> 1. In the small packet case it recycles the skb before copying data out...
> Not good if new data arrives overwriting existing data.
>
> 2. Macros like RX_PKT_BUF_SZ that depend on local variables are evil!!
Very interesting!
2.6.22 doesn't include ssb, does it?
Adding CCs to make reporters of another bugreport aware of this.
--
Greetings Michael.
next prev parent reply other threads:[~2007-05-26 17:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 0:24 b44: regression in 2.6.22 Stephen Hemminger
2007-05-26 3:51 ` Gary Zambrano
2007-05-26 17:01 ` Michael Buesch [this message]
[not found] ` <200705261901.18110.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-27 19:25 ` b44: regression in 2.6.22 (resend) Maximilian Engelhardt
[not found] ` <200705272125.25506.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-05-27 19:45 ` Michael Buesch
[not found] ` <200705272145.00796.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-27 20:36 ` Maximilian Engelhardt
[not found] ` <200705272236.42628.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-05-27 20:46 ` Michael Buesch
[not found] ` <200705272246.16960.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-27 21:46 ` Maximilian Engelhardt
2007-05-27 21:13 ` Michael Buesch
2007-05-27 21:16 ` Michael Buesch
[not found] ` <200705272316.07338.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-27 21:50 ` Maximilian Engelhardt
[not found] ` <200705272313.33129.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-27 22:15 ` Maximilian Engelhardt
2007-05-28 0:24 ` Michael Buesch
[not found] ` <200705280224.40506.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-28 0:40 ` Maximilian Engelhardt
[not found] ` <200705280240.17910.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-05-28 10:16 ` Michael Buesch
[not found] ` <200705281216.51690.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-28 14:09 ` Maximilian Engelhardt
[not found] ` <200705281609.49859.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-05-28 15:14 ` Michael Buesch
[not found] ` <200705281714.25841.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-28 15:32 ` Thomas Gleixner
2007-05-28 15:43 ` Michael Buesch
2007-05-28 17:44 ` Maximilian Engelhardt
2007-05-28 19:23 ` Thomas Gleixner
2007-05-28 20:55 ` Maximilian Engelhardt
2007-05-28 21:45 ` Thomas Gleixner
2007-05-29 18:28 ` Maximilian Engelhardt
[not found] ` <200705282255.56490.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-05-29 13:58 ` Gary Zambrano
[not found] ` <1180447123.17146.4.camel-opBMJL+S1+nCw/J+WP9nZ0NK2P1VvzQgpWgKQ6/u3Fg@public.gmane.org>
2007-05-29 17:23 ` Maximilian Engelhardt
2007-06-03 16:26 ` Maximilian Engelhardt
[not found] ` <200706031826.06891.maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>
2007-06-04 6:39 ` Thomas Gleixner
2007-06-04 16:09 ` Stephen Hemminger
2007-06-04 16:35 ` Thomas Gleixner
2007-06-04 16:59 ` iperf: performance regression (was b44 driver problem?) Stephen Hemminger
2007-06-04 17:32 ` Thomas Gleixner
2007-06-04 17:51 ` Stephen Hemminger
2007-06-04 19:00 ` Thomas Gleixner
2007-06-04 19:26 ` Thomas Gleixner
2007-06-04 19:32 ` Ingo Molnar
2007-06-04 19:47 ` Maximilian Engelhardt
2007-06-04 20:02 ` Stephen Hemminger
2007-06-04 20:52 ` Maximilian Engelhardt
2007-05-28 10:49 ` b44: regression in 2.6.22 (resend) Michael Buesch
[not found] ` <200705281249.56106.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-28 14:12 ` Maximilian Engelhardt
2007-05-28 14:55 ` Michael Buesch
2007-05-29 14:14 ` Gary Zambrano
[not found] ` <1180448075.17146.12.camel-opBMJL+S1+nCw/J+WP9nZ0NK2P1VvzQgpWgKQ6/u3Fg@public.gmane.org>
2007-05-29 20:45 ` Michael Buesch
[not found] ` <200705292245.22940.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-05-29 21:01 ` Stephen Hemminger
2007-05-29 21:05 ` Gary Zambrano
[not found] ` <1180472741.17711.19.camel-opBMJL+S1+nCw/J+WP9nZ0NK2P1VvzQgpWgKQ6/u3Fg@public.gmane.org>
2007-05-29 22:39 ` Jeff Garzik
[not found] ` <465CABA3.10003-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2007-05-29 21:36 ` Gary Zambrano
2007-05-30 10:45 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705261901.18110.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=maxi@daemonizer.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=uwe.bugla@gmx.de \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).