From: Michael Buesch <mb@bu3sch.de>
To: John Linville <linville@tuxdriver.com>
Cc: Gary Zambrano <zambrano@broadcom.com>, netdev@vger.kernel.org
Subject: b44-ssb: Remove redundant device reset
Date: Sun, 27 May 2007 17:14:48 +0200 [thread overview]
Message-ID: <200705271714.48272.mb@bu3sch.de> (raw)
This reset wasn't there in the old b44 driver
and I don't think it's needed for the 47xx either.
If it later turns out that this is really needed for
some weird 47xx, we can re-add it with a special case
branch for that particular device.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: bu3sch-wireless-dev/drivers/net/b44.c
===================================================================
--- bu3sch-wireless-dev.orig/drivers/net/b44.c 2007-05-27 16:59:22.000000000 +0200
+++ bu3sch-wireless-dev/drivers/net/b44.c 2007-05-27 17:03:32.000000000 +0200
@@ -2201,11 +2201,6 @@
printk("%2.2x%c", dev->dev_addr[i],
i == 5 ? '\n' : ':');
- /* Initialize phy */
- spin_lock_irq(&bp->lock);
- b44_chip_reset(bp);
- spin_unlock_irq(&bp->lock);
-
return 0;
err_out_free_dev:
--
Greetings Michael.
reply other threads:[~2007-05-27 15:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705271714.48272.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).