From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Laurent Chavey" <chavey@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: bond_compute_features() does not handle devices with different CSUM
Date: Wed, 30 May 2007 09:27:57 -0700 [thread overview]
Message-ID: <20070530092757.3417fb52@freepuppy> (raw)
In-Reply-To: <97949e3e0705291741t4c485d38ud48b06e6d07e31bc@mail.gmail.com>
On Tue, 29 May 2007 17:41:45 -0700
"Laurent Chavey" <chavey@google.com> wrote:
> kernel version <= 2.6.20.1
> file drivers/net/bonding/bonding_main.c
> function bond_compute_features()
>
> -----------
> Given a system with two different NIC. One driver sets
> dev->features |= NETIF_F_HW_CSUM
> the other driver sets
> dev->features |= NETIF_F_IP_CSUM
>
> when enslaving the 2 device above, bond_compute_features()
> does not set the intersection of the 2 CSUM
> features (should be NETIF_F_IP_CSUM)
> -----------
>
> should the bond features in the case above include NETIF_F_IP_CSUM
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
The bridge code already has a more complete/complex recompute
routine to handle this.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-30 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 0:41 bond_compute_features() does not handle devices with different CSUM Laurent Chavey
2007-05-30 2:47 ` Laurent Chavey
2007-05-30 11:03 ` Michael Buesch
2007-05-30 15:16 ` Laurent Chavey
2007-05-30 15:18 ` Laurent Chavey
2007-05-30 16:27 ` Stephen Hemminger [this message]
2007-05-30 16:58 ` Laurent Chavey
2007-05-30 17:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530092757.3417fb52@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=chavey@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).