From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Baruch Even <baruch@ev-en.org>,
netdev@vger.kernel.org, power@bughost.org,
bridge@linux-foundation.org
Subject: [PATCH 2/2] bridge: round off STP perodic timers
Date: Wed, 30 May 2007 12:14:22 -0700 [thread overview]
Message-ID: <20070530121422.0cdd90eb@freepuppy> (raw)
In-Reply-To: <20070530121252.1248f506@freepuppy>
Peroidic STP timers don't have to be exact.
The hold timer runs at 1HZ, and the hello timer normally runs
at 2HZ; save power by aligning it them to next second.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
net/bridge/br_stp.c | 3 ++-
net/bridge/br_stp_timer.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
--- a/net/bridge/br_stp.c 2007-05-30 11:42:16.000000000 -0700
+++ b/net/bridge/br_stp.c 2007-05-30 11:51:51.000000000 -0700
@@ -178,7 +178,8 @@ void br_transmit_config(struct net_bridg
br_send_config_bpdu(p, &bpdu);
p->topology_change_ack = 0;
p->config_pending = 0;
- mod_timer(&p->hold_timer, jiffies + BR_HOLD_TIME);
+ mod_timer(&p->hold_timer,
+ round_jiffies(jiffies + BR_HOLD_TIME));
}
}
--- a/net/bridge/br_stp_timer.c 2007-05-30 11:42:16.000000000 -0700
+++ b/net/bridge/br_stp_timer.c 2007-05-30 11:53:08.000000000 -0700
@@ -42,7 +42,7 @@ static void br_hello_timer_expired(unsig
if (br->dev->flags & IFF_UP) {
br_config_bpdu_generation(br);
- mod_timer(&br->hello_timer, jiffies + br->hello_time);
+ mod_timer(&br->hello_timer, round_jiffies(jiffies + br->hello_time));
}
spin_unlock(&br->lock);
}
next prev parent reply other threads:[~2007-05-30 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 22:46 [PATCH] Reduce frequency of cleanup timer in bridge Baruch Even
2007-05-30 19:12 ` [PATCH 1/2] bridge: reduce frequency of forwarding " Stephen Hemminger
2007-05-30 19:14 ` Stephen Hemminger [this message]
2007-05-31 8:21 ` [PATCH 2/2] bridge: round off STP perodic timers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530121422.0cdd90eb@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=baruch@ev-en.org \
--cc=bridge@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=power@bughost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox