From: Michael Buesch <mb@bu3sch.de>
To: "Laurent Chavey" <chavey@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: bond_compute_features() does not handle devices with different CSUM
Date: Wed, 30 May 2007 13:03:24 +0200 [thread overview]
Message-ID: <200705301303.25119.mb@bu3sch.de> (raw)
In-Reply-To: <97949e3e0705291947j7fa5cd3fy5afe7f5eb898252c@mail.gmail.com>
On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote:
> proposed change.
>
> --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29
> 19:43:39.010565000 -0700
> +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-29
> 19:46:12.376980000 -0700
> @@ -1227,7 +1227,14 @@
> int i;
>
> bond_for_each_slave(bond, slave, i) {
> - features &= (slave->dev->features & BOND_INTERSECT_FEATURES);
> + /* NETIF_F_HW_CSUM includes support for NET_IF_IP_CSUM
> + * as such when looking for the intersection we need to
> + * add it to the device supported features
> + */
> + unsigned long dev_features = slave->dev->features;
> + if (slave->dev->features & NETIF_F_HW_CSUM)
> + dev_features |= NETIF_F_IP_CSUM;
> + features &= (features & BOND_INTERSECT_FEATURES);
Is this statement correct?
It's the same as
features = features & (features & BOND_INTERSECT_FEATURES);
which looks strange to me.
Did you mean something like
features |= (dev_features & BOND_INTERSECT_FEATURES);
?
--
Greetings Michael.
next prev parent reply other threads:[~2007-05-30 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 0:41 bond_compute_features() does not handle devices with different CSUM Laurent Chavey
2007-05-30 2:47 ` Laurent Chavey
2007-05-30 11:03 ` Michael Buesch [this message]
2007-05-30 15:16 ` Laurent Chavey
2007-05-30 15:18 ` Laurent Chavey
2007-05-30 16:27 ` Stephen Hemminger
2007-05-30 16:58 ` Laurent Chavey
2007-05-30 17:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705301303.25119.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=chavey@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).