From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out
Date: Thu, 31 May 2007 01:42:41 -0700 (PDT) [thread overview]
Message-ID: <20070531.014241.28790645.davem@davemloft.net> (raw)
In-Reply-To: <11801685623173-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 26 May 2007 11:35:56 +0300
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@helsinki.fi>
>
> It is easily calculable when needed and user are not that many
> after all.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
This looks good, but are you absolutely sure we never used
a stale value of tp->left_out on purpose?
I tried to audit this but there are so many cases :-)
What I mean here is, was there a case where we updated
sacked_out or lost_out, but then used left_out before
it was updated, and we were doing this on purpose?
next prev parent reply other threads:[~2007-05-31 8:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 8:35 [PATCH 0/9]: tcp-2.6 patchset Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h & remove it Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 6/9] [TCP]: Reorganize lost marking code Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 9/9] [RFC] [TCP]: Kill tp->fackets_out (tcp_sock diet program) Ilpo Järvinen
2007-07-03 5:00 ` [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue David Miller
2007-07-03 11:08 ` Ilpo Järvinen
2007-05-31 8:44 ` [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq David Miller
2007-05-27 7:38 ` [PATCH 6/9] [TCP]: Reorganize lost marking code Ilpo Järvinen
2007-05-31 8:44 ` David Miller
2007-05-31 8:43 ` [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h & remove it David Miller
2007-05-31 8:43 ` [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint David Miller
2007-05-31 8:42 ` David Miller [this message]
2007-05-31 16:31 ` [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out Ilpo Järvinen
2007-07-03 5:02 ` David Miller
2007-05-31 8:40 ` [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting David Miller
2007-05-31 8:39 ` [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier David Miller
2007-05-26 23:44 ` [PATCH 0/9]: tcp-2.6 patchset David Miller
2007-05-27 7:58 ` Ilpo Järvinen
2007-05-27 9:11 ` David Miller
2007-05-27 11:16 ` Ilpo Järvinen
2007-05-27 14:04 ` Baruch Even
2007-05-27 16:56 ` Ilpo Järvinen
2007-05-28 10:27 ` Ilpo Järvinen
2007-05-29 16:14 ` Stephen Hemminger
2007-05-29 20:07 ` Ilpo Järvinen
2007-05-29 20:19 ` Stephen Hemminger
2007-05-29 20:58 ` Ilpo Järvinen
2007-05-29 21:15 ` Stephen Hemminger
2007-05-30 9:10 ` [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) Ilpo Järvinen
2007-06-01 4:38 ` David Miller
2007-06-01 11:22 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531.014241.28790645.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).