From: David Miller <davem@davemloft.net>
To: mark@glines.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] use default 32768-61000 outgoing port range in all cases
Date: Thu, 31 May 2007 15:43:47 -0700 (PDT) [thread overview]
Message-ID: <20070531.154347.24896889.davem@davemloft.net> (raw)
In-Reply-To: <20070515155054.394f4032@chirp>
From: Mark Glines <mark@glines.org>
Date: Tue, 15 May 2007 15:50:54 -0700
> I noticed I had chopped off a whole comment, when I meant to only remove
> part of it. So I've fixed that.
>
> This is a reissued use-high-ports-for-local-stuff.diff, with a comment
> fix. Does anyone have a problem with this patch in its current form?
> Any chance of applying it?
>
> This diff changes the default port range used for outgoing connections,
> from "use 32768-61000 in most cases, but use N-4999 on small boxes
> (where N is a multiple of 1024, depending on just *how* small the box
> is)" to just "use 32768-61000 in all cases".
>
> I don't believe there are any drawbacks to this change, and it keeps
> outgoing connection ports farther away from the mess of IANA-registered
> ports.
>
> Signed-off-by: Mark Glines <mark@glines.org>
Sorry for taking forever to wrap my brain around this, I think your
patch is the way to go and I will merge it.
The code was trying to match the allowed port range with the sizing
of the bind hash table, which is hashed by local port number. But
even considering that I think it's OK to use the full range by
default, always.
Thanks a lot.
prev parent reply other threads:[~2007-05-31 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 22:50 [PATCH] use default 32768-61000 outgoing port range in all cases Mark Glines
2007-05-31 22:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531.154347.24896889.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mark@glines.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).