From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Thomas Klein <osstklei@de.ibm.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Christoph Raisch <raisch@de.ibm.com>,
"Jan-Bernd Themann" <ossthema@de.ibm.com>,
"Jan-Bernd Themann" <themann@de.ibm.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"linux-ppc" <linuxppc-dev@ozlabs.org>,
Marcus Eder <meder@de.ibm.com>, netdev <netdev@vger.kernel.org>,
Thomas Klein <tklein@de.ibm.com>,
Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] ehea: Receive SKB Aggregation
Date: Thu, 31 May 2007 09:37:03 -0700 [thread overview]
Message-ID: <20070531093703.373995b2@freepuppy> (raw)
In-Reply-To: <200705311354.56979.osstklei@de.ibm.com>
>
>
> +static int try_get_ip_tcp_hdr(struct ehea_cqe *cqe, struct sk_buff *skb,
> + struct iphdr **iph, struct tcphdr **tcph)
> +{
> + int ip_len;
> +
> + /* non tcp/udp packets */
> + if (!cqe->header_length)
> + return -1;
> +
> + /* non tcp packet */
> + *iph = (struct iphdr *)(skb->data);
Why the indirection, copying of headers..
> + if ((*iph)->protocol != IPPROTO_TCP)
> + return -1;
> +
> + ip_len = (u8)((*iph)->ihl);
> + ip_len <<= 2;
> + *tcph = (struct tcphdr *)(((u64)*iph) + ip_len);
> +
> + return 0;
> +}
> +
>
This code seems to be duplicating a lot (but not all) of the TCP/IP
input path validation checks. This is a security problem if nothing else...
Also, how do you prevent DoS attacks from hostile TCP senders that send
huge number of back to back frames?
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-31 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 11:54 [PATCH 2/2] ehea: Receive SKB Aggregation Thomas Klein
2007-05-31 13:41 ` Christoph Hellwig
2007-06-04 12:09 ` Christoph Raisch
2007-05-31 16:37 ` Stephen Hemminger [this message]
2007-06-04 12:09 ` Christoph Raisch
-- strict thread matches above, loose matches on Subject: below --
2007-07-04 10:09 [PATCH 2/2] eHEA: " Jan-Bernd Themann
2007-07-10 17:00 ` Jeff Garzik
2007-07-05 7:26 Jan-Bernd Themann
2007-07-05 8:20 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531093703.373995b2@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).