netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tim Mann <mann@vmware.com>
To: netdev@vger.kernel.org
Cc: mann@vmware.com
Subject: small forcedeth WoL fix
Date: Fri, 1 Jun 2007 17:22:17 -0700	[thread overview]
Message-ID: <20070601172217.686a0d5e@mann-lx.eng.vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

I happened to notice that a system with an NVidia NIC using the
forcedeth driver won't wake-on-LAN if the interface was in promiscuous
mode when you power off.  By experiment, it looks like
the hardware needs to have NvRegPacketFilterFlags set to
NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive unicast packets to my
address) in order for WoL to work.  At any rate, the attached patch
fixes the problem for me.

-- 
Tim Mann  work: mann@vmware.com  home: tim@tim-mann.org
          http://www.vmware.com  http://tim-mann.org

[-- Attachment #2: wol-fix.patch --]
[-- Type: text/x-patch, Size: 360 bytes --]

--- forcedeth-git-netdev.c	2007-06-01 16:43:19.971507000 -0700
+++ forcedeth-git-netdev-fixed.c	2007-06-01 16:46:53.389713000 -0700
@@ -4830,8 +4830,10 @@
 
 	drain_ring(dev);
 
-	if (np->wolenabled)
+	if (np->wolenabled) {
+		writel(NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR, base + NvRegPacketFilterFlags);
 		nv_start_rx(dev);
+	}
 
 	/* FIXME: power down nic */
 

             reply	other threads:[~2007-06-02  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02  0:22 Tim Mann [this message]
2007-06-13 20:38 ` small forcedeth WoL fix Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070601172217.686a0d5e@mann-lx.eng.vmware.com \
    --to=mann@vmware.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).