From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: mchan@broadcom.com, andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [2/5 revised][BNX2]: Add missing wait in bnx2_init_5709_context().
Date: Mon, 04 Jun 2007 21:22:33 -0700 (PDT) [thread overview]
Message-ID: <20070604.212233.52182487.davem@davemloft.net> (raw)
In-Reply-To: <20070605012351.GE31462@havoc.gtf.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Mon, 4 Jun 2007 21:23:51 -0400
> On Mon, Jun 04, 2007 at 05:58:49PM -0700, Michael Chan wrote:
> > [BNX2]: Add missing wait in bnx2_init_5709_context().
> >
> > For correctness, we need to wait for the MEM_INIT bit to be cleared
> > in the BNX2_CTX_COMMAND register before proceeding.
> >
> > [Added return -EBUSY when the MEM_INIT bit doesn't clear, suggested
> > by Jeff Garzik.]
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> ACK
Applied, thanks.
prev parent reply other threads:[~2007-06-05 4:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 0:00 [2/5][BNX2]: Add missing wait in bnx2_init_5709_context() Michael Chan
2007-06-04 23:39 ` Jeff Garzik
2007-06-05 0:58 ` [2/5 revised][BNX2]: " Michael Chan
2007-06-05 1:23 ` Jeff Garzik
2007-06-05 4:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604.212233.52182487.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).