From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][RFC] network splice receive
Date: Tue, 5 Jun 2007 17:34:55 +0400 [thread overview]
Message-ID: <20070605133455.GA3111@2ka.mipt.ru> (raw)
In-Reply-To: <20070605080542.GA9909@kernel.dk>
On Tue, Jun 05, 2007 at 10:05:43AM +0200, Jens Axboe (jens.axboe@oracle.com) wrote:
> Hi,
Hi Jens.
> Here's an implementation of tcp network splice receive support. It's
> originally based on the patch set that Intel posted some time ago, but
> has been (close to) 100% reworked.
>
> Now, I'm not a networking guru by any stretch of the imagination, so I'd
> like some input on the direction of the main patch. Is the approach
> feasible? Glaring errors? Missing bits?
First one - you seems to create new data_ready callback
tcp_splice_data_ready(), but it is unused, and actually can not be at
all - there will be a deadlock, since sk_data_ready can be called with locked
socket and also in bh context.
I will setup this and report abck about bugs.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-06-05 13:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 8:05 [PATCH][RFC] network splice receive Jens Axboe
2007-06-05 11:45 ` Jens Axboe
2007-06-05 12:20 ` Jens Axboe
2007-06-05 12:34 ` jamal
2007-06-06 7:14 ` Jens Axboe
2007-06-05 13:34 ` Evgeniy Polyakov [this message]
2007-06-05 14:31 ` Evgeniy Polyakov
2007-06-05 14:49 ` Evgeniy Polyakov
2007-06-06 7:17 ` Jens Axboe
2007-06-07 8:09 ` Evgeniy Polyakov
2007-06-07 10:51 ` Jens Axboe
2007-06-07 14:58 ` Evgeniy Polyakov
2007-06-08 7:48 ` Jens Axboe
2007-06-08 8:06 ` David Miller
2007-06-08 8:38 ` Jens Axboe
2007-06-08 8:56 ` Evgeniy Polyakov
2007-06-08 9:04 ` Jens Axboe
2007-06-08 13:58 ` Evgeniy Polyakov
2007-06-08 14:14 ` Jens Axboe
2007-06-08 14:57 ` Evgeniy Polyakov
2007-06-08 15:19 ` Jens Axboe
2007-06-08 15:30 ` Evgeniy Polyakov
2007-06-09 6:36 ` Jens Axboe
2007-06-12 11:29 ` Evgeniy Polyakov
2007-06-12 11:33 ` Jens Axboe
2007-06-12 12:35 ` Evgeniy Polyakov
2007-06-12 12:40 ` Jens Axboe
2007-06-12 13:11 ` Evgeniy Polyakov
2007-06-12 13:11 ` Jens Axboe
2007-06-11 8:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605133455.GA3111@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=jens.axboe@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).