From: Patrick McHardy <kaber@trash.net>
To: netdev@vger.kernel.org
Cc: socketcan@hartkopp.net, hadi@cyberus.ca, xemul@sw.ru,
Patrick McHardy <kaber@trash.net>,
ebiederm@xmission.com, tgraf@suug.ch
Subject: [RFC DUMMY 05/09]: Use dev->stats
Date: Tue, 5 Jun 2007 16:12:59 +0200 (MEST) [thread overview]
Message-ID: <20070605141258.15650.44308.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070605141250.15650.47178.sendpatchset@localhost.localdomain>
[DUMMY]: Use dev->stats
Use dev->stats instead of netdev_priv().
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit c5178079b5d191e34a516dc111be862e3382e32b
tree 339bf81b1270b51272a1e9ebc643188dc755a2ee
parent 0323e7d1e7d5042492684264cfcba6d7ff55c473
author Patrick McHardy <kaber@trash.net> Tue, 05 Jun 2007 15:40:28 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 05 Jun 2007 15:40:28 +0200
drivers/net/dummy.c | 16 +++-------------
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c
index 60673bc..91b474c 100644
--- a/drivers/net/dummy.c
+++ b/drivers/net/dummy.c
@@ -38,7 +38,6 @@
static int numdummies = 1;
static int dummy_xmit(struct sk_buff *skb, struct net_device *dev);
-static struct net_device_stats *dummy_get_stats(struct net_device *dev);
static int dummy_set_address(struct net_device *dev, void *p)
{
@@ -59,7 +58,6 @@ static void set_multicast_list(struct net_device *dev)
static void __init dummy_setup(struct net_device *dev)
{
/* Initialize the device structure. */
- dev->get_stats = dummy_get_stats;
dev->hard_start_xmit = dummy_xmit;
dev->set_multicast_list = set_multicast_list;
dev->set_mac_address = dummy_set_address;
@@ -76,20 +74,13 @@ static void __init dummy_setup(struct net_device *dev)
static int dummy_xmit(struct sk_buff *skb, struct net_device *dev)
{
- struct net_device_stats *stats = netdev_priv(dev);
-
- stats->tx_packets++;
- stats->tx_bytes+=skb->len;
+ dev->stats.tx_packets++;
+ dev->stats.tx_bytes += skb->len;
dev_kfree_skb(skb);
return 0;
}
-static struct net_device_stats *dummy_get_stats(struct net_device *dev)
-{
- return netdev_priv(dev);
-}
-
static struct net_device **dummies;
/* Number of dummy devices to be set up by this module. */
@@ -101,8 +92,7 @@ static int __init dummy_init_one(int index)
struct net_device *dev_dummy;
int err;
- dev_dummy = alloc_netdev(sizeof(struct net_device_stats),
- "dummy%d", dummy_setup);
+ dev_dummy = alloc_netdev(0, "dummy%d", dummy_setup);
if (!dev_dummy)
return -ENOMEM;
next prev parent reply other threads:[~2007-06-05 14:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 14:12 [RFC RTNETLINK 00/09]: Netlink link creation API Patrick McHardy
2007-06-05 14:12 ` [RFC NETLINK 01/09]: Mark netlink policies const Patrick McHardy
2007-06-05 19:39 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 02/09]: ifindex 0 does not exist Patrick McHardy
2007-06-05 19:40 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 03/09]: Split up rtnl_setlink Patrick McHardy
2007-06-05 19:41 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 04/09]: Link creation API Patrick McHardy
2007-06-05 19:43 ` David Miller
2007-06-05 21:09 ` Patrick McHardy
2007-06-05 22:03 ` Stephen Hemminger
2007-06-05 23:17 ` Patrick McHardy
2007-06-05 23:16 ` Stephen Hemminger
2007-06-06 11:42 ` Patrick McHardy
2007-06-06 16:37 ` Eric W. Biederman
2007-06-06 16:50 ` Patrick McHardy
2007-06-06 18:02 ` Eric W. Biederman
2007-06-05 14:12 ` Patrick McHardy [this message]
2007-06-05 19:44 ` [RFC DUMMY 05/09]: Use dev->stats David Miller
2007-06-05 14:13 ` [RFC DUMMY 06/09]: Keep dummy devices on list Patrick McHardy
2007-06-05 19:44 ` David Miller
2007-06-05 14:13 ` [RFC DUMMY 07/09]: Use rtnl_link API Patrick McHardy
2007-06-05 19:46 ` David Miller
2007-06-05 14:13 ` [RFC IFB 08/09]: Keep ifb devices on list Patrick McHardy
2007-06-05 14:13 ` [RFC IFB 09/09]: Use rtnl_link API Patrick McHardy
2007-06-05 14:18 ` [RFC IPROUTE]: iplink: use netlink for link configuration Patrick McHardy
2007-06-05 19:37 ` [RFC RTNETLINK 00/09]: Netlink link creation API David Miller
2007-06-05 21:10 ` Patrick McHardy
2007-06-05 22:00 ` jamal
2007-06-05 22:07 ` Patrick McHardy
2007-06-05 22:29 ` jamal
2007-06-06 0:40 ` Eric W. Biederman
2007-06-06 11:50 ` Patrick McHardy
2007-06-06 15:25 ` Eric W. Biederman
2007-06-06 15:35 ` Patrick McHardy
2007-06-06 15:56 ` Alexey Kuznetsov
2007-06-06 16:32 ` Patrick McHardy
2007-06-06 17:31 ` Eric W. Biederman
2007-06-06 19:14 ` Alexey Kuznetsov
2007-06-07 8:06 ` Eric W. Biederman
2007-06-06 16:13 ` Eric W. Biederman
2007-06-06 16:25 ` Patrick McHardy
2007-06-06 13:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605141258.15650.44308.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=ebiederm@xmission.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=tgraf@suug.ch \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).