From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: paul.moore@hp.com, netdev@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/2] NetLabel: consolidate the struct socket/sock handling to just struct sock
Date: Thu, 07 Jun 2007 18:37:21 -0700 (PDT) [thread overview]
Message-ID: <20070607.183721.87999873.davem@davemloft.net> (raw)
In-Reply-To: <Line.LNX.4.64.0706072118090.10435@d.namei>
From: James Morris <jmorris@namei.org>
Date: Thu, 7 Jun 2007 21:18:26 -0400 (EDT)
> On Thu, 7 Jun 2007, Paul Moore wrote:
>
> > The current NetLabel code has some redundant APIs which allow both
> > "struct socket" and "struct sock" types to be used; this may have made sense at
> > some point but it is wasteful now. Remove the functions that operate on
> > sockets and convert the callers. Not only does this make the code smaller and
> > more consistent but it pushes the locking burden up to the caller which can be
> > more intelligent about the locks. Also, perform the same conversion (socket
> > to sock) on the SELinux/NetLabel glue code where it make sense.
> >
> > Signed-off-by: Paul Moore <paul.moore@hp.com>
>
> Acked-by: James Morris <jmorris@namei.org>
Applied.
next prev parent reply other threads:[~2007-06-08 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 15:32 [PATCH 0/2] NetLabel cleanups Paul Moore
2007-06-07 15:32 ` [PATCH 1/2] NetLabel: consolidate the struct socket/sock handling to just struct sock Paul Moore
2007-06-08 1:18 ` James Morris
2007-06-08 1:37 ` David Miller [this message]
2007-06-07 15:32 ` [PATCH 2/2] fix several unaligned kernel accesses in the CIPSO engine Paul Moore
2007-06-08 1:20 ` James Morris
2007-06-08 1:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607.183721.87999873.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).