From: linas@austin.ibm.com (Linas Vepstas)
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] spidernet: checksum and ethtool
Date: Thu, 7 Jun 2007 11:45:11 -0500 [thread overview]
Message-ID: <20070607164511.GO28472@austin.ibm.com> (raw)
In-Reply-To: <20070529172436.3cd60dcf@freepuppy>
On Tue, May 29, 2007 at 05:24:36PM -0700, Stephen Hemminger wrote:
> It doesn't look like spidernet hardware can really checksum all protocols,
> the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM
> instead of NETIF_F_HW_CSUM.
>
> The driver doesn't need it's own get/set for ethtool tx csum, and it
> should use the standard ethtool_op_get_link.
Can you provide a signed-off-by line, please? I was hoping to submit
upstream today.
--linas
next prev parent reply other threads:[~2007-06-07 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 0:24 [PATCH] spidernet: checksum and ethtool Stephen Hemminger
2007-06-01 23:06 ` Linas Vepstas
2007-06-07 16:45 ` Linas Vepstas [this message]
2007-06-07 18:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607164511.GO28472@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).