From: Michael Buesch <mb@bu3sch.de>
To: Mithlesh Thukral <mithlesh@netxen.com>
Cc: netdev@vger.kernel.org, amitkale@netxen.com, jeff@garzik.org,
netxenproj@linsyssoft.com, rob@netxen.com
Subject: Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address
Date: Sun, 10 Jun 2007 11:59:25 +0200 [thread overview]
Message-ID: <200706101159.25756.mb@bu3sch.de> (raw)
In-Reply-To: <200706101154.11746.mb@bu3sch.de>
On Sunday 10 June 2007 11:54:11 Michael Buesch wrote:
> > +int netxen_nic_set_mcast_addr(struct netxen_adapter *adapter, int index,
> > + u8 *addr)
> > +{
> > + u32 hi = 0;
> > + u32 lo = 0;
> > + u16 port = physical_port[adapter->portnum];
> > +
> > + hi = (u32) addr[0] |
> > + ((u32) addr[1] << 8) |
> > + ((u32) addr[2] << 16);
> > + lo = (u32) addr[3] |
> > + ((u32) addr[4] << 8) |
> > + ((u32) addr[5] << 16);
>
> That is the correct solution. Do that above, too.
>
> > + netxen_crb_writelit_adapter(adapter, NETXEN_MCAST_ADDR(port,index), hi);
> > + netxen_crb_writelit_adapter(adapter, NETXEN_MCAST_ADDR(port,index) + 4,
> > + hi);
> > + return 0;
> > +}
Well, actually no. It is broken, too. You write hi twice. And I would
swap the variable names, as "low" is addr[0] in my understanding.
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-10 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 11:34 [PATCH 3/4] NetXen: Add correct routines to setup multicast address Mithlesh Thukral
2007-06-10 9:54 ` Michael Buesch
2007-06-10 9:59 ` Michael Buesch [this message]
2007-06-13 4:48 ` Dhananjay Phadke
2007-06-13 7:12 ` Mithlesh Thukral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706101159.25756.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=amitkale@netxen.com \
--cc=jeff@garzik.org \
--cc=mithlesh@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).