netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] mac80211: Set low initial rate in rc80211_simple
Date: Mon, 11 Jun 2007 21:24:11 -0400	[thread overview]
Message-ID: <20070612012411.GI20422@tuxdriver.com> (raw)
In-Reply-To: <20070612012319.GH20422@tuxdriver.com>

From: Larry Finger <Larry.Finger@lwfinger.net>

The initial rate for STA's using rc80211_simple is set to the last
rate in the rate table. For situations for which the signal is weak,
the rate may be too high for authentication and association. Although
the rc80211_simple module will adjust the speed, the response may not
be fast enough for a successful connection. This modification sets the
initial rate to the lowest supported value.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 net/mac80211/rc80211_simple.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
index 2048cfd..5ae7fc4 100644
--- a/net/mac80211/rc80211_simple.c
+++ b/net/mac80211/rc80211_simple.c
@@ -283,14 +283,16 @@ static void rate_control_simple_rate_init(void *priv, void *priv_sta,
 	int i;
 	sta->txrate = 0;
 	mode = local->oper_hw_mode;
-	/* TODO: what is a good starting rate for STA? About middle? Maybe not
-	 * the lowest or the highest rate.. Could consider using RSSI from
-	 * previous packets? Need to have IEEE 802.1X auth succeed immediately
-	 * after assoc.. */
+	/* TODO: This routine should consider using RSSI from previous packets
+	 * as we need to have IEEE 802.1X auth succeed immediately after assoc..
+	 * Until that method is implemented, we will use the lowest supported rate
+	 * as a workaround, */
 	for (i = 0; i < mode->num_rates; i++) {
 		if ((sta->supp_rates & BIT(i)) &&
-		    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
+		    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED)) {
 			sta->txrate = i;
+			break;
+		}
 	}
 }
 
-- 
1.5.0.6

-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-06-12  1:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-11  1:17 [GIT]: net-2.6.23 tree available David Miller
2007-06-11 11:12 ` Patrick McHardy
2007-06-11 20:50   ` David Miller
2007-06-11 20:52     ` Patrick McHardy
     [not found] ` <20070610.181704.73383002.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-06-12  1:22   ` mac80211 patches for 2.6.23 John W. Linville
2007-06-12  1:23     ` [PATCH] mac80211: Add support for SIOCGIWRATE ioctl to provide rate information John W. Linville
2007-06-12  1:24       ` John W. Linville [this message]
     [not found]         ` <20070612012411.GI20422-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-07-03  5:38           ` [PATCH] mac80211: Set low initial rate in rc80211_simple David Miller
     [not found]       ` <20070612012319.GH20422-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-07-03  5:38         ` [PATCH] mac80211: Add support for SIOCGIWRATE ioctl to provide rate information David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070612012411.GI20422@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).