From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: billfink@mindspring.com, sangtae.ha@gmail.com, rhee@eos.ncsu.edu,
rhee@ncsu.edu, netdev@vger.kernel.org
Subject: [PATCH] TCP: remove initial_ssthresh from Cubic
Date: Wed, 13 Jun 2007 10:27:18 -0700 [thread overview]
Message-ID: <20070613102718.61d67a36@localhost> (raw)
In-Reply-To: <20070613.005642.85685043.davem@davemloft.net>
Remove the initial slow start override from TCP cubic.
The old code caused Cubic to start out in slow start mode, which
is less agressive but caused slow performance.
The administrator can override initial slow start threshold on any
TCP congestion control method via the TCP route metrics.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/net/ipv4/tcp_cubic.c 2007-06-13 10:18:38.000000000 -0700
+++ b/net/ipv4/tcp_cubic.c 2007-06-13 10:19:19.000000000 -0700
@@ -29,7 +29,6 @@
static int fast_convergence __read_mostly = 1;
static int max_increment __read_mostly = 16;
static int beta __read_mostly = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */
-static int initial_ssthresh __read_mostly = 100;
static int bic_scale __read_mostly = 41;
static int tcp_friendliness __read_mostly = 1;
@@ -44,8 +43,6 @@ module_param(max_increment, int, 0644);
MODULE_PARM_DESC(max_increment, "Limit on increment allowed during binary search");
module_param(beta, int, 0444);
MODULE_PARM_DESC(beta, "beta for multiplicative increase");
-module_param(initial_ssthresh, int, 0644);
-MODULE_PARM_DESC(initial_ssthresh, "initial value of slow start threshold");
module_param(bic_scale, int, 0444);
MODULE_PARM_DESC(bic_scale, "scale (scaled by 1024) value for bic function (bic_scale/1024)");
module_param(tcp_friendliness, int, 0644);
@@ -87,8 +84,6 @@ static inline void bictcp_reset(struct b
static void bictcp_init(struct sock *sk)
{
bictcp_reset(inet_csk_ca(sk));
- if (initial_ssthresh)
- tcp_sk(sk)->snd_ssthresh = initial_ssthresh;
}
/* calculate the cubic root of x using a table lookup followed by one
next prev parent reply other threads:[~2007-06-13 17:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 0:37 2.6.20.7 TCP cubic (and bic) initial slow start way too slow? Bill Fink
2007-05-08 9:41 ` SANGTAE HA
2007-05-09 6:31 ` Bill Fink
2007-05-10 15:32 ` Bill Fink
2007-05-10 17:31 ` SANGTAE HA
2007-05-10 18:39 ` rhee
2007-05-10 20:35 ` David Miller
2007-05-10 20:45 ` Stephen Hemminger
2007-05-10 20:57 ` Injong Rhee
2007-05-12 16:07 ` Bill Fink
2007-05-12 16:45 ` SANGTAE HA
2007-05-16 6:44 ` Bill Fink
2007-06-12 22:12 ` David Miller
2007-06-13 0:16 ` Stephen Hemminger
2007-06-13 3:38 ` Bill Fink
2007-06-13 7:56 ` David Miller
2007-06-13 17:27 ` Stephen Hemminger [this message]
2007-06-13 18:26 ` [PATCH] TCP: remove initial_ssthresh from Cubic David Miller
2007-06-13 18:31 ` Stephen Hemminger
2007-06-13 18:46 ` David Miller
2007-06-14 4:03 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613102718.61d67a36@localhost \
--to=shemminger@linux-foundation.org \
--cc=billfink@mindspring.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rhee@eos.ncsu.edu \
--cc=rhee@ncsu.edu \
--cc=sangtae.ha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).