From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Dan Aloni <da-x@monatomic.org>,
Chad Tindel <ctindel@users.sourceforge.net>,
Jay Vosburgh <fubar@us.ibm.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix race condition about network device name allocation
Date: Wed, 13 Jun 2007 15:53:35 -0700 [thread overview]
Message-ID: <20070613155335.47111c67@localhost> (raw)
In-Reply-To: <20070613094521.GA8860@localdomain>
Bonding refers to device after unregistering. This has always been
a dangerous thing. The following UNTESTED should fix the problem.
--- a/drivers/net/bonding/bond_sysfs.c 2007-06-13 15:48:37.000000000 -0700
+++ b/drivers/net/bonding/bond_sysfs.c 2007-06-13 15:49:17.000000000 -0700
@@ -164,9 +164,10 @@ static ssize_t bonding_store_bonds(struc
printk(KERN_INFO DRV_NAME
": %s is being deleted...\n",
bond->dev->name);
- unregister_netdevice(bond->dev);
+
bond_deinit(bond->dev);
bond_destroy_sysfs_entry(bond);
+ unregister_netdevice(bond->dev);
rtnl_unlock();
goto out;
}
next prev parent reply other threads:[~2007-06-13 22:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 5:40 [BUG][PATCH] Fix race condition about network device name allocation Kenji Kaneshige
2007-05-11 15:50 ` Stephen Hemminger
2007-05-11 16:25 ` Stephen Hemminger
2007-05-14 1:33 ` Kenji Kaneshige
2007-05-14 15:41 ` Stephen Hemminger
2007-05-14 8:17 ` Kenji Kaneshige
2007-05-14 15:58 ` [PATCH] " Stephen Hemminger
2007-06-13 9:45 ` Dan Aloni
2007-06-13 16:36 ` Stephen Hemminger
2007-06-14 6:07 ` Dan Aloni
2007-06-13 22:53 ` Stephen Hemminger [this message]
2007-06-14 4:36 ` Jay Vosburgh
2007-06-19 15:23 ` Why is this patch not in 2.6.22-rc5? Stephen Hemminger
2007-06-19 17:52 ` Jeff Garzik
2007-06-19 18:12 ` [PATCH] bonding: Fix use after free in unregister path Jay Vosburgh
2007-06-20 23:12 ` Jeff Garzik
2007-06-21 0:09 ` Chris Wright
2007-06-19 22:04 ` Why is this patch not in 2.6.22-rc5? David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613155335.47111c67@localhost \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bonding-devel@lists.sourceforge.net \
--cc=ctindel@users.sourceforge.net \
--cc=da-x@monatomic.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).