netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	koster@debian.org.tw, socketcan@hartkopp.net,
	urs@isnogud.escape.de
Subject: Re: [IPV6] addrconf: Fix IPv6 on tuntap tunnels
Date: Thu, 14 Jun 2007 13:03:58 -0700 (PDT)	[thread overview]
Message-ID: <20070614.130358.90120374.davem@davemloft.net> (raw)
In-Reply-To: <20070614081607.GA22931@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 14 Jun 2007 18:16:07 +1000

> [IPV6] addrconf: Fix IPv6 on tuntap tunnels
> 
> The recent patch that added ipv6_hwtype is broken on tuntap tunnels.
> Indeed, it's broken on any device that does not pass the ipv6_hwtype
> test.
> 
> The reason is that the original test only applies to autoconfiguration,
> not IPv6 support.  IPv6 support is allowed on any device.  In fact,
> even with the ipv6_hwtype patch applied you can still add IPv6 addresses
> to any interface that doesn't pass thw ipv6_hwtype test provided that
> they have a sufficiently large MTU.  This is a serious problem because
> come deregistration time these devices won't be cleaned up properly.
> 
> I've gone back and looked at the rationale for the patch.  It appears
> that the real problem is that we were creating IPv6 devices even if the
> MTU was too small.  So here's a patch which fixes that and reverts the
> ipv6_hwtype stuff.
> 
> Thanks to Kanru Chen for reporting this issue.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks for fixing this up Herbert.

Patch applied.

  reply	other threads:[~2007-06-14 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14  8:16 [IPV6] addrconf: Fix IPv6 on tuntap tunnels Herbert Xu
2007-06-14 20:03 ` David Miller [this message]
2007-06-15  9:20   ` Oliver Hartkopp
2007-06-15 20:42     ` Vlad Yasevich
2007-06-15 22:14       ` David Miller
2007-06-16  7:55         ` Herbert Xu
2007-06-18 17:56           ` Vlad Yasevich
2007-06-16 12:33         ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614.130358.90120374.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=koster@debian.org.tw \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=urs@isnogud.escape.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).