From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Ilpo =?UTF-8?B?SsOkcnZpbmVuIg==?=
<ilpo.jarvinen@helsinki.fi>"@smtp2.linux-foundation.org
Cc: David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-2.6] [TCP]: Congestion control API RTT sampling fix
Date: Fri, 15 Jun 2007 07:32:55 -0700 [thread overview]
Message-ID: <20070615073255.733f64e3@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0706151227330.15358@kivilampi-30.cs.helsinki.fi>
On Fri, 15 Jun 2007 12:30:12 +0300 (EEST)
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> wrote:
> Commit 164891aadf1721fca4dce473bb0e0998181537c6 broke RTT
> sampling of congestion control modules. Inaccurate timestamps
> could be fed to them without providing any way for them to
> identify such cases. Previously RTT sampler was called only if
> FLAG_RETRANS_DATA_ACKED was not set filtering inaccurate
> timestamps nicely. In addition, the new behavior could give an
> invalid timestamp (zero) to RTT sampler if only skbs with
> TCPCB_RETRANS were ACKed. This solves both problems.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
Yes, let's get this in 2.6.22
next prev parent reply other threads:[~2007-06-15 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 9:30 [PATCH net-2.6] [TCP]: Congestion control API RTT sampling fix Ilpo Järvinen
2007-06-15 14:32 ` Stephen Hemminger [this message]
2007-06-15 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070615073255.733f64e3@localhost \
--to=shemminger@linux-foundation.org \
--cc="Ilpo =?UTF-8?B?SsOkcnZpbmVuIg==?= <ilpo.jarvinen@helsinki.fi>"@smtp2.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).