From: Michael Buesch <mb@bu3sch.de>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Kieran Mansley <kmansley@solarflare.com>,
xen-devel@lists.xensource.com, netdev@vger.kernel.org,
herbert@gondor.apana.org.au
Subject: Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules
Date: Fri, 15 Jun 2007 14:21:01 +0200 [thread overview]
Message-ID: <200706151421.01608.mb@bu3sch.de> (raw)
In-Reply-To: <C29842A2.9328%Keir.Fraser@cl.cam.ac.uk>
On Friday 15 June 2007 14:20:34 Keir Fraser wrote:
>
> On 15/6/07 13:11, "Michael Buesch" <mb@bu3sch.de> wrote:
>
> >> No use of the following please:
> >> If (foo) return 1; else return 0;
> >> Is clearer as:
> >> Return foo;
> >
> > But it's not the same.
> > return !!foo;
> > would be the same. And yes, it does matter:
>
> True in general, but not the cases I've seen in this patchset, where 'foo'
> is a predicate.
Ok, if foo is a variable containing an error code, it's
better to return that error code. I assumed that foo is a
variable containing some value (counter or something).
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-15 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 10:46 [PATCH 0/4] [Net] Support accelerated network plugin modules Kieran Mansley
2007-06-15 11:26 ` Keir Fraser
2007-06-15 12:11 ` [Xen-devel] " Michael Buesch
2007-06-15 12:20 ` Keir Fraser
2007-06-15 12:21 ` Michael Buesch [this message]
2007-06-15 12:29 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706151421.01608.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=herbert@gondor.apana.org.au \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).