Re: b44: high ping times with wireless-dev

[Michael Buesch <mb@bu3sch.de>]

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

On Saturday 16 June 2007 23:27:43 Maximilian Engelhardt wrote:
> [...]
> ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 10
> ACPI: PCI Interrupt 0000:02:02.0[A] -> Link [LNKD] -> GSI 10 (level, low) -> 
> IRQ 10
> ssb: Sonics Silicon Backplane found on PCI device 0000:02:02.0
> b44.c:v2.0
> eth0: Broadcom 44xx/47xx 10/100BaseT Ethernet 00:c0:9f:29:99:a7
> [...]

Ok, I prepared two debugging patches.

Please enable SonicsSiliconBackplane Debugging in the kernel kconfig,
so I can get more detail information about your card.
Device Drivers/Sonics Silicon Backplane/SSB debugging
(Must disable "No SSB kernel messages")

Please apply and test the attached debugging patches in a row.
So apply patch 1 and test if it works again. If not, apply
patch 2 and test if it works.
Always save complete dmesg log on each test run and send it to me.

Thanks for testing.
(This time it seems we are actually getting somewhere, when
dealing with sane people. :D )

-- 
Greetings Michael.

[-- Attachment #2: b44-irqs-test1.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]

Index: bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c
===================================================================
--- bu3sch-wireless-dev.orig/drivers/ssb/driver_pcicore.c	2007-04-07 17:19:03.000000000 +0200
+++ bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c	2007-06-17 12:51:37.000000000 +0200
@@ -477,6 +477,7 @@ int ssb_pcicore_dev_irqvecs_enable(struc
 		goto out;
 	bus = pdev->bus;
 
+printk("Enabling IRQ vectors\n");
 	/* Enable interrupts for this device. */
 	if (bus->host_pci &&
 	    ((pdev->id.revision >= 6) || (pdev->id.coreid == SSB_DEV_PCIE))) {
@@ -497,8 +498,10 @@ int ssb_pcicore_dev_irqvecs_enable(struc
 
 		intvec = ssb_read32(pdev, SSB_INTVEC);
 		tmp = ssb_read32(dev, SSB_TPSFLAG);
+printk("Writing INTVEC. TPSFLAG is 0x%08X\n", tmp);
 		tmp &= SSB_TPSFLAG_BPFLAG;
-		intvec |= tmp;
+//		intvec |= tmp;
+intvec |= 0x00000002;
 		ssb_write32(pdev, SSB_INTVEC, intvec);
 	}
 

[-- Attachment #3: b44-irqs-test2.patch --]
[-- Type: text/x-diff, Size: 844 bytes --]

Index: bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c
===================================================================
--- bu3sch-wireless-dev.orig/drivers/ssb/driver_pcicore.c	2007-06-17 12:50:32.000000000 +0200
+++ bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c	2007-06-17 12:51:32.000000000 +0200
@@ -514,6 +514,8 @@ intvec |= 0x00000002;
 		tmp |= SSB_PCICORE_SBTOPCI_BURST;
 		pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
 
+printk("Wrote translation\n");
+#if 0
 		if (pdev->id.revision < 5) {
 			tmp = ssb_read32(pdev, SSB_IMCFGLO);
 			tmp &= ~SSB_IMCFGLO_SERTO;
@@ -527,6 +529,7 @@ intvec |= 0x00000002;
 			tmp |= SSB_PCICORE_SBTOPCI_MRM;
 			pcicore_write32(pc, SSB_PCICORE_SBTOPCI2, tmp);
 		}
+#endif
 	} else {
 		assert(pdev->id.coreid == SSB_DEV_PCIE);
 		//TODO: Better make defines for all these magic PCIE values.