From: Michael Buesch <mb@bu3sch.de>
To: John Linville <linville@tuxdriver.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org,
Maximilian Engelhardt <maxi@daemonizer.de>,
Gary Zambrano <zambrano@broadcom.com>
Subject: [PATCH] b44-ssb: Fix IRQ routing bits on the backplane
Date: Sun, 17 Jun 2007 14:52:38 +0200 [thread overview]
Message-ID: <200706171452.38383.mb@bu3sch.de> (raw)
The backplane on the b44 chip seems to have a silicon bug
in the IRQ routing. The ethernet core IRQ routing does not work
with the routing bit returned from the backplaneflag register.
This patch adds a workaround for the b44 chip to use a hardcoded
constant. This constant was also used in the old b44 driver.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: Maximilian Engelhardt <maxi@daemonizer.de>
Cc: Gary Zambrano <zambrano@broadcom.com>
Index: bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c
===================================================================
--- bu3sch-wireless-dev.orig/drivers/ssb/driver_pcicore.c 2007-06-17 13:35:45.000000000 +0200
+++ bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c 2007-06-17 14:19:05.000000000 +0200
@@ -496,9 +496,15 @@ int ssb_pcicore_dev_irqvecs_enable(struc
u32 intvec;
intvec = ssb_read32(pdev, SSB_INTVEC);
- tmp = ssb_read32(dev, SSB_TPSFLAG);
- tmp &= SSB_TPSFLAG_BPFLAG;
- intvec |= tmp;
+ if ((bus->chip_id & 0xFF00) == 0x4400) {
+ /* Workaround: On the BCM44XX the BPFLAG routing
+ * bit is wrong. Use a hardcoded constant. */
+ intvec |= 0x00000002;
+ } else {
+ tmp = ssb_read32(dev, SSB_TPSFLAG);
+ tmp &= SSB_TPSFLAG_BPFLAG;
+ intvec |= tmp;
+ }
ssb_write32(pdev, SSB_INTVEC, intvec);
}
Please apply this to wireless-dev.
This is also most likely the bug Uwe Bugla was
bullshitting about^W^Wreporting.
--
Greetings Michael.
next reply other threads:[~2007-06-17 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-17 12:52 Michael Buesch [this message]
2007-06-17 15:21 ` [PATCH] b44-ssb: Fix IRQ routing bits on the backplane Maximilian Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706171452.38383.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=linville@tuxdriver.com \
--cc=maxi@daemonizer.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).