From: Frank Pavlic <fpavlic@de.ibm.com>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org
Subject: [PATCH 4/8] s390: qeth: wrong packet length in qdio header
Date: Wed, 20 Jun 2007 12:59:14 +0200 [thread overview]
Message-ID: <20070620105914.GD9454@de.ibm.com> (raw)
In-Reply-To: <20070620104817.GA2627@de.ibm.com>
From: Frank Pavlic <fpavlic@de.ibm.com>
Packets Length in qdio header is broken when using
EDDP on Layer2 devices. This leads to skb_under_panic on receiver
system when running on z/VM GuestLAN devices.
Signed-off-by: Frank Pavlic <fpavlic@de.ibm.com>
---
drivers/s390/net/qeth_eddp.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_eddp.c b/drivers/s390/net/qeth_eddp.c
index 4640f32..70108fb 100644
--- a/drivers/s390/net/qeth_eddp.c
+++ b/drivers/s390/net/qeth_eddp.c
@@ -424,8 +424,7 @@ __qeth_eddp_fill_context_tcp(struct qeth_eddp_context *ctx,
/* prepare qdio hdr */
if (eddp->qh.hdr.l2.id == QETH_HEADER_TYPE_LAYER2){
eddp->qh.hdr.l2.pkt_length = data_len + ETH_HLEN +
- eddp->nhl + eddp->thl -
- sizeof(struct qeth_hdr);
+ eddp->nhl + eddp->thl;
#ifdef CONFIG_QETH_VLAN
if (eddp->mac.h_proto == __constant_htons(ETH_P_8021Q))
eddp->qh.hdr.l2.pkt_length += VLAN_HLEN;
--
1.5.2.1
next prev parent reply other threads:[~2007-06-20 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 10:48 [PATCH 0/8] s390: network device driver fixes Frank Pavlic
2007-06-20 10:55 ` [PATCH 1/8] s390: print correct level for HiperSockets devices Frank Pavlic
2007-06-20 23:13 ` Jeff Garzik
2007-06-20 10:56 ` [PATCH 2/8] s390: qeth driver does not recover Frank Pavlic
2007-06-20 10:58 ` [PATCH 3/8] s390: avoid inconsistent lock state in qeth Frank Pavlic
2007-06-20 10:59 ` Frank Pavlic [this message]
2007-06-20 11:00 ` [PATCH 5/8] s390: Use ccw_device_get_id() in qeth/claw drivers Frank Pavlic
2007-06-20 11:01 ` [PATCH 6/8] s390: don't call iucv_path_connect from tasklet context Frank Pavlic
2007-06-20 11:02 ` [PATCH 7/8] s390: netiucv spinlock initializer cleanup Frank Pavlic
2007-06-20 11:03 ` [PATCH 8/8] s390: netiucv inlining cleanup Frank Pavlic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620105914.GD9454@de.ibm.com \
--to=fpavlic@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).