netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Pavlic <fpavlic@de.ibm.com>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org
Subject: [PATCH 6/8] s390: don't call iucv_path_connect from tasklet context
Date: Wed, 20 Jun 2007 13:01:30 +0200	[thread overview]
Message-ID: <20070620110130.GF9454@de.ibm.com> (raw)
In-Reply-To: <20070620104817.GA2627@de.ibm.com>

From: Ursula Braun <braunu@de.ibm.com>

net/iucv/iucv.c creates the requirement for
iucv_path_connect not to be called from tasklet context anymore.
An extra checking is added in case of a failing netiucv_tx
to fulfil this requirement for netiucv.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Pavlic <fpavlic@de.ibm.com>
---
 drivers/s390/net/netiucv.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c
index c358764..648ee13 100644
--- a/drivers/s390/net/netiucv.c
+++ b/drivers/s390/net/netiucv.c
@@ -1315,7 +1315,8 @@ static int netiucv_tx(struct sk_buff *skb, struct net_device *dev)
 	 * and throw away packet.
 	 */
 	if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
-		fsm_event(privptr->fsm, DEV_EVENT_START, dev);
+		if (!in_atomic())
+			fsm_event(privptr->fsm, DEV_EVENT_START, dev);
 		dev_kfree_skb(skb);
 		privptr->stats.tx_dropped++;
 		privptr->stats.tx_errors++;
-- 
1.5.2.1


  parent reply	other threads:[~2007-06-20 10:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 10:48 [PATCH 0/8] s390: network device driver fixes Frank Pavlic
2007-06-20 10:55 ` [PATCH 1/8] s390: print correct level for HiperSockets devices Frank Pavlic
2007-06-20 23:13   ` Jeff Garzik
2007-06-20 10:56 ` [PATCH 2/8] s390: qeth driver does not recover Frank Pavlic
2007-06-20 10:58 ` [PATCH 3/8] s390: avoid inconsistent lock state in qeth Frank Pavlic
2007-06-20 10:59 ` [PATCH 4/8] s390: qeth: wrong packet length in qdio header Frank Pavlic
2007-06-20 11:00 ` [PATCH 5/8] s390: Use ccw_device_get_id() in qeth/claw drivers Frank Pavlic
2007-06-20 11:01 ` Frank Pavlic [this message]
2007-06-20 11:02 ` [PATCH 7/8] s390: netiucv spinlock initializer cleanup Frank Pavlic
2007-06-20 11:03 ` [PATCH 8/8] s390: netiucv inlining cleanup Frank Pavlic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620110130.GF9454@de.ibm.com \
    --to=fpavlic@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).