netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: netdev@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>,
	shemminger@linux-foundation.org, davem@davemloft.net,
	jeff@garzik.org
Subject: [RFC NET 00/02]: Secondary unicast address support
Date: Wed, 20 Jun 2007 20:00:22 +0200 (MEST)	[thread overview]
Message-ID: <20070620180017.6685.70611.sendpatchset@localhost.localdomain> (raw)

These two patches contain a first short at secondary unicast address support.
I'm still working on converting macvlan as an example, but since I'm about to
leave for tonight I thougth I'd get them out for some comments now.

The patch adds two new functions dev_unicast_add and dev_unicast_delete to
add/remove addresses. Similar to dev_mc_add/dev_mc_delete they do refcounting
of the addresses and the address on a list associated with the device.

dev_address_upload is responsible for uploading both the multicast and
unicast list to the device. Devices that are capable of filtering multiple
unicast addresses need to provide a function dev->set_address_list that
deals with setting both unicast and multicast address filters. This seemed
like the easiest way for chips containing filters that can be used for
any address type, also parts of the logic when to use HW filters is similar
for unicast and multicast addresses. Devices not providing this function
are put in promiscous mode when secondary addresses are present and the
old set_multicast_list function is called to take care of multicast
filtering.

The dev_uc_list structure is kept similar to dev_mc_list to allow easier
integration in existing "fill address filters" loops.

E1000 is converted as an example, the patch worked fine in some limited
testing.

Comments welcome.


 drivers/net/e1000/e1000_main.c |   39 ++++++---
 include/linux/netdevice.h      |   17 ++++
 net/core/dev.c                 |  172 ++++++++++++++++++++++++++++++++++++++--
 net/core/dev_mcast.c           |   34 +-------
 4 files changed, 212 insertions(+), 50 deletions(-)

Patrick McHardy (2):
      [NET]: Secondary unicast address support
      [E1000]: Secondary unicast address support

             reply	other threads:[~2007-06-20 18:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 18:00 Patrick McHardy [this message]
2007-06-20 18:00 ` [RFC NET 01/02]: Secondary unicast address support Patrick McHardy
2007-06-20 18:00 ` [RFC E1000 02/02]: " Patrick McHardy
2007-06-21 19:08 ` [RFC NET 00/02]: " Eric W. Biederman
2007-06-21 19:13   ` David Miller
2007-06-21 21:11     ` Caitlin Bestler
2007-06-21 19:13   ` Patrick McHardy
2007-06-21 20:31     ` Eric W. Biederman
2007-06-22  0:08       ` Patrick McHardy
2007-06-22  3:30         ` Ben Greear
2007-06-22  4:30           ` Eric W. Biederman
2007-06-22 12:08             ` Ben Greear
2007-06-22  1:56       ` Patrick McHardy
2007-06-22  3:21         ` Ben Greear
2007-06-22 11:36           ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620180017.6685.70611.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).