From: Olof Johansson <olof@lixom.net>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org
Subject: [PATCH 6/9] pasemi_mac: Simplify memcpy for short receives
Date: Fri, 22 Jun 2007 15:05:36 -0500 [thread overview]
Message-ID: <20070622200536.GG11723@lixom.net> (raw)
In-Reply-To: 20070622194720.614405000@lixom.net
[-- Attachment #1: pasemi_mac-bugfix --]
[-- Type: text/plain, Size: 732 bytes --]
No need to copy over the skipped align bytes (besides, NET_IP_ALIGN is
0 on ppc64).
Signed-off-by: Olof Johansson <olof@lixom.net>
Index: netdev-2.6/drivers/net/pasemi_mac.c
===================================================================
--- netdev-2.6.orig/drivers/net/pasemi_mac.c
+++ netdev-2.6/drivers/net/pasemi_mac.c
@@ -516,9 +516,7 @@ static int pasemi_mac_clean_rx(struct pa
netdev_alloc_skb(mac->netdev, len + NET_IP_ALIGN);
if (new_skb) {
skb_reserve(new_skb, NET_IP_ALIGN);
- memcpy(new_skb->data - NET_IP_ALIGN,
- skb->data - NET_IP_ALIGN,
- len + NET_IP_ALIGN);
+ memcpy(new_skb->data, skb->data, len);
/* save the skb in buffer_info as good */
skb = new_skb;
}
--
next prev parent reply other threads:[~2007-06-22 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070622194720.614405000@lixom.net>
2007-06-22 20:04 ` [PATCH 1/9] pasemi_mac: Fix TX interrupt threshold Olof Johansson
2007-07-02 12:37 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 2/9] pasemi_mac: Clean TX ring in poll Olof Johansson
2007-07-02 12:34 ` Jeff Garzik
2007-07-03 20:31 ` Olof Johansson
2007-06-22 20:05 ` [PATCH 3/9] pasemi_mac: Abstract out register access Olof Johansson
2007-07-02 12:32 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 4/9] pasemi_mac: Use MMIO instead of pci config accessors Olof Johansson
2007-07-02 12:37 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 5/9] pasemi_mac: Enable L2 caching of packet headers Olof Johansson
2007-06-22 20:05 ` Olof Johansson [this message]
2007-06-22 20:05 ` [PATCH 7/9] pasemi_mac: Minor performance tweaks Olof Johansson
2007-06-22 20:05 ` [PATCH 8/9] pasemi_mac: Reduce locking when cleaning TX ring Olof Johansson
2007-06-22 20:05 ` [PATCH 9/9] pasemi_mac: Enable LLTX Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622200536.GG11723@lixom.net \
--to=olof@lixom.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).