From: David Miller <davem@davemloft.net>
To: konstantin.sharlaimov@gmail.com
Cc: paulus@samba.org, vsu@altlinux.ru, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when decoding mppe
Date: Sat, 23 Jun 2007 23:07:02 -0700 (PDT) [thread overview]
Message-ID: <20070623.230702.60547745.davem@davemloft.net> (raw)
In-Reply-To: <4679116E.9050507@gmail.com>
From: Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>
Date: Wed, 20 Jun 2007 22:37:18 +1100
> The mppe_decompress() function required a buffer that is 1 byte too small when
> receiving a message of mru size. This fixes buffer allocation to prevent this
> from occurring.
>
> Signed-off-by: Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>
This looks better, I've reverted the original version of the
fix and applied this new one.
> --- linux-2.6.21.3/drivers/net/ppp_generic.c.orig 2007-06-20 09:14:13.000000000
> +1100
> +++ linux-2.6.21.3/drivers/net/ppp_generic.c 2007-06-20 09:18:06.000000000 +1100
Please prevent your email client from corrupting patches like
this by adding new lines.
I've fixed up your patches by hand now twice, I'm not going to do it
any more.
Thanks.
next prev parent reply other threads:[~2007-06-24 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 11:37 [RFC] [PATCH 2.6.21.5] ppp: fix osize too small errors when decoding mppe Konstantin Sharlaimov
2007-06-24 6:07 ` David Miller [this message]
2007-06-24 23:38 ` Konstantin Sharlaimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623.230702.60547745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=konstantin.sharlaimov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).