From: David Miller <davem@davemloft.net>
To: okir@lst.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Make skb_seq_read unmap the last fragment
Date: Sat, 23 Jun 2007 23:12:07 -0700 (PDT) [thread overview]
Message-ID: <20070623.231207.44965284.davem@davemloft.net> (raw)
In-Reply-To: <200706190956.26252.okir@lst.de>
From: Olaf Kirch <okir@lst.de>
Date: Tue, 19 Jun 2007 09:56:24 +0200
> From: Olaf Kirch <olaf.kirch@oracle.com>
>
> Make skb_seq_read unmap the last fragment
>
> Having walked through the entire skbuff, skb_seq_read would leave the
> last fragment mapped. As a consequence, the unwary caller would leak
> kmaps, and proceed with preempt_count off by one. The only (kind of
> non-intuitive) workaround is to use skb_seq_read_abort.
>
> This patch makes sure skb_seq_read always unmaps frag_data after having
> cycled through the skb's paged part.
>
> Signed-off-by: olaf.kirch@oracle.com
Thanks for finding and fixing this bug.
Patch applied, thanks again Olaf.
prev parent reply other threads:[~2007-06-24 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 7:56 [PATCH] net: Make skb_seq_read unmap the last fragment Olaf Kirch
2007-06-24 6:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623.231207.44965284.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okir@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).