From: Michael Buesch <mb@bu3sch.de>
To: "C. Scott Ananian" <cscott@laptop.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration
Date: Sat, 23 Jun 2007 01:42:41 +0200 [thread overview]
Message-ID: <200706230142.41188.mb@bu3sch.de> (raw)
In-Reply-To: <c6d9bea0706221626h434d17d0l6dc3a6a513601546@mail.gmail.com>
On Saturday 23 June 2007 01:26:19 C. Scott Ananian wrote:
> +struct rdns6_info {
> + rwlock_t lock;
> + struct timer_list expiry_timer;
> + struct rdns6_entry * rdnss_list;
> + struct inet6_dev * in6_dev; /* back pointer for netlink notify */
> + int expire_all : 1, /* remove entries on ifdown */
> + free_me : 1; /* safely free this struct */
> +};
Sparse will complain about that.
I suggest you do:
+struct rdns6_info {
+ rwlock_t lock;
+ struct timer_list expiry_timer;
+ struct rdns6_entry * rdnss_list;
+ struct inet6_dev * in6_dev; /* back pointer for netlink notify */
+ u8 expire_all; /* remove entries on ifdown */
+ u8 free_me; /* safely free this struct */
+};
Will generate better code and
struct size shouldn't increase. So it's a net win.
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-22 23:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 23:26 [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration C. Scott Ananian
2007-06-22 23:39 ` Michael Buesch
2007-06-23 0:09 ` C. Scott Ananian
2007-06-23 2:11 ` Dan Williams
2007-06-23 9:07 ` Michael Buesch
2007-06-23 20:41 ` David Miller
2007-06-22 23:42 ` Michael Buesch [this message]
2007-06-23 1:04 ` David Stevens
2007-06-23 1:17 ` Simon Arlott
2007-06-23 4:30 ` David Stevens
2007-06-23 4:50 ` Simon Arlott
2007-06-23 5:12 ` David Miller
2007-06-23 8:23 ` Pierre Ynard
2007-06-24 19:05 ` Olaf Kirch
2007-06-23 13:25 ` Rémi Denis-Courmont
2007-06-23 14:47 ` C. Scott Ananian
2007-06-23 16:40 ` Simon Arlott
2007-06-23 16:48 ` David Stevens
2007-06-23 16:51 ` Rémi Denis-Courmont
2007-06-23 17:45 ` David Stevens
2007-06-23 18:13 ` Rémi Denis-Courmont
2007-06-23 18:51 ` David Stevens
2007-06-23 19:18 ` Rémi Denis-Courmont
2007-06-23 20:27 ` Pierre Ynard
2007-06-25 2:17 ` Dan Williams
2007-06-25 2:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706230142.41188.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=cscott@laptop.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).