netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "pradeep singh" <pradeep.rautela@gmail.com>
Cc: trivial@kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2
Date: Sat, 23 Jun 2007 09:54:46 -0700	[thread overview]
Message-ID: <20070623095446.c1a9c697.akpm@linux-foundation.org> (raw)
In-Reply-To: <a901b49a0706210618q7c22cbe0jd6f7e052a8e05a97@mail.gmail.com>

> On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <pradeep.rautela@gmail.com> wrote:
> Hi,
> My mistake.
> Resending after reformatting the patch by hand.
> Looks like gmail messes the plain text patches.
> 

That's still mangled so I typed it in again.

Please always include a full changlog with each version of a patch.

I do not know what this patch does - please provide a changelog.  In this
case it should tell us whether and how this null pointer deref is actually
occuring and if so, why.

As well as a full description of the problem which it solves, a changelog
should also describe _how_ it solved it, but that is sufficiently obvious
in this case.


Thanks.

  reply	other threads:[~2007-06-23 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21 12:53 [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2 pradeep singh
2007-06-21 13:00 ` pradeep singh
2007-06-21 13:18 ` pradeep singh
2007-06-23 16:54   ` Andrew Morton [this message]
2007-06-25  5:46     ` pradeep singh
2007-06-25 22:34   ` Andrew Morton
2007-06-25 23:14     ` Jeff Garzik
2007-06-25 23:30       ` Andrew Morton
2007-06-25 23:32         ` Jeff Garzik
2007-06-26 16:24         ` Divy Le Ray
2007-06-25 23:15     ` Jeff Garzik
2007-06-26  0:38       ` Stephen Hemminger
2007-06-27  6:30 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070623095446.c1a9c697.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=pradeep.rautela@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).