* [NET] au1000_eth: Fix warnings.
@ 2007-06-24 13:59 Ralf Baechle
2007-06-25 23:02 ` Andrew Morton
2007-06-27 6:33 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Ralf Baechle @ 2007-06-24 13:59 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik, netdev
Fixed by including <linux/dma-mapping.h>:
CC drivers/net/au1000_eth.o
drivers/net/au1000_eth.c: In function 'au1000_probe':
drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent'
drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent'
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index c39ab80..c27cfce 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -34,7 +34,7 @@
*
*
*/
-
+#include <linux/dma-mapping.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/string.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [NET] au1000_eth: Fix warnings.
2007-06-24 13:59 [NET] au1000_eth: Fix warnings Ralf Baechle
@ 2007-06-25 23:02 ` Andrew Morton
2007-06-26 11:42 ` Ralf Baechle
2007-06-27 6:33 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-06-25 23:02 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Jeff Garzik, netdev
On Sun, 24 Jun 2007 15:59:54 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:
> Fixed by including <linux/dma-mapping.h>:
>
> CC drivers/net/au1000_eth.o
> drivers/net/au1000_eth.c: In function 'au1000_probe':
> drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent'
> drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent'
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index c39ab80..c27cfce 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -34,7 +34,7 @@
> *
> *
> */
> -
> +#include <linux/dma-mapping.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/string.h>
That's more than a warning fix. On most platforms, dma_alloc_noncoherent()
is a #define so the driver just won't link there.
<looks>
But the driver is mips-only, and MIPS uses a regular C function for
dma_alloc_noncoherent(), so you got lucky.
Still, I'd say this is for-2.6.22.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [NET] au1000_eth: Fix warnings.
2007-06-25 23:02 ` Andrew Morton
@ 2007-06-26 11:42 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2007-06-26 11:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeff Garzik, netdev
On Mon, Jun 25, 2007 at 04:02:16PM -0700, Andrew Morton wrote:
> That's more than a warning fix. On most platforms, dma_alloc_noncoherent()
> is a #define so the driver just won't link there.
>
> <looks>
>
> But the driver is mips-only, and MIPS uses a regular C function for
> dma_alloc_noncoherent(), so you got lucky.
Yep, the way this driver is being used (32-bit only) it happens to just
work.
> Still, I'd say this is for-2.6.22.
Yep.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [NET] au1000_eth: Fix warnings.
2007-06-24 13:59 [NET] au1000_eth: Fix warnings Ralf Baechle
2007-06-25 23:02 ` Andrew Morton
@ 2007-06-27 6:33 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-06-27 6:33 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, netdev
Ralf Baechle wrote:
> Fixed by including <linux/dma-mapping.h>:
>
> CC drivers/net/au1000_eth.o
> drivers/net/au1000_eth.c: In function 'au1000_probe':
> drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent'
> drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent'
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-27 6:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-24 13:59 [NET] au1000_eth: Fix warnings Ralf Baechle
2007-06-25 23:02 ` Andrew Morton
2007-06-26 11:42 ` Ralf Baechle
2007-06-27 6:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).