From: Andrew Morton <akpm@linux-foundation.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [NET] au1000_eth: Fix warnings.
Date: Mon, 25 Jun 2007 16:02:16 -0700 [thread overview]
Message-ID: <20070625160216.e9e29d7f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070624135953.GA16754@linux-mips.org>
On Sun, 24 Jun 2007 15:59:54 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:
> Fixed by including <linux/dma-mapping.h>:
>
> CC drivers/net/au1000_eth.o
> drivers/net/au1000_eth.c: In function 'au1000_probe':
> drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent'
> drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent'
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index c39ab80..c27cfce 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -34,7 +34,7 @@
> *
> *
> */
> -
> +#include <linux/dma-mapping.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/string.h>
That's more than a warning fix. On most platforms, dma_alloc_noncoherent()
is a #define so the driver just won't link there.
<looks>
But the driver is mips-only, and MIPS uses a regular C function for
dma_alloc_noncoherent(), so you got lucky.
Still, I'd say this is for-2.6.22.
next prev parent reply other threads:[~2007-06-25 23:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 13:59 [NET] au1000_eth: Fix warnings Ralf Baechle
2007-06-25 23:02 ` Andrew Morton [this message]
2007-06-26 11:42 ` Ralf Baechle
2007-06-27 6:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625160216.e9e29d7f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).