From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [NET] au1000_eth: Fix warnings.
Date: Tue, 26 Jun 2007 13:42:42 +0200 [thread overview]
Message-ID: <20070626114242.GB14930@linux-mips.org> (raw)
In-Reply-To: <20070625160216.e9e29d7f.akpm@linux-foundation.org>
On Mon, Jun 25, 2007 at 04:02:16PM -0700, Andrew Morton wrote:
> That's more than a warning fix. On most platforms, dma_alloc_noncoherent()
> is a #define so the driver just won't link there.
>
> <looks>
>
> But the driver is mips-only, and MIPS uses a regular C function for
> dma_alloc_noncoherent(), so you got lucky.
Yep, the way this driver is being used (32-bit only) it happens to just
work.
> Still, I'd say this is for-2.6.22.
Yep.
Ralf
next prev parent reply other threads:[~2007-06-26 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 13:59 [NET] au1000_eth: Fix warnings Ralf Baechle
2007-06-25 23:02 ` Andrew Morton
2007-06-26 11:42 ` Ralf Baechle [this message]
2007-06-27 6:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626114242.GB14930@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).