From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: kaber@trash.net, herbert.xu@redhat.com, netdev@vger.kernel.org,
mchan@broadcom.com
Subject: Re: [RFC] IPV6 checksum offloading in network devices
Date: Wed, 27 Jun 2007 00:44:53 -0700 (PDT) [thread overview]
Message-ID: <20070627.004453.55726417.davem@davemloft.net> (raw)
In-Reply-To: <20070530140034.13bbf971@freepuppy>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 30 May 2007 14:00:34 -0700
> This is better.
> There is still a possiblity when a device allows IPV6 and not IPV4
> checksumming, that the checksum will be done in the fixup code in
> dev_queue_xmit.
>
> The existing model for checksum offload does not correctly handle
> devices that can offload IPV4 and IPV6 only. The NETIF_F_HW_CSUM flag
> implies device can do any arbitrary protocol.
>
> This patch:
> * adds NETIF_F_IPV6_CSUM for those devices
> * fixes bnx2 and tg3 devices that need it
> * add NETIF_F_IPV6_CSUM to ipv6 output (incl GSO)
> * fixes assumptions about NETIF_F_ALL_CSUM in nat
> * adjusts bridge union of checksumming computation
I've applied this to net-2.6.23, we can back it out or rework
it if there are problems.
Several of these checksum feature tests are getting out of
hand :-)
prev parent reply other threads:[~2007-06-27 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 20:58 Definition and usage of NETIF_F_HW_SUM? Stephen Hemminger
2007-05-29 21:36 ` Herbert Xu
2007-05-29 21:58 ` Stephen Hemminger
2007-05-30 0:10 ` Michael Chan
2007-05-29 23:45 ` Stephen Hemminger
2007-06-04 15:35 ` Ron Mercer
2007-05-30 15:53 ` [RFC] IPV6 checksum offloading in network devices Stephen Hemminger
2007-05-30 16:13 ` Patrick McHardy
2007-05-30 21:00 ` Stephen Hemminger
2007-06-27 7:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627.004453.55726417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert.xu@redhat.com \
--cc=kaber@trash.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).