From: Steve Wise <swise@opengridcomputing.com>
To: rdreier@cisco.com
Cc: netdev@vger.kernel.org, divy@chelsio.com,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: [ofa-general] [PATCH 5/6] iw_cxgb3: Don't post TID_RELEASE message.
Date: Wed, 27 Jun 2007 10:51:45 -0500 [thread overview]
Message-ID: <20070627155145.24944.64064.stgit@dell3.ogc.int> (raw)
In-Reply-To: <20070627155119.24944.44172.stgit@dell3.ogc.int>
iw_cxgb3: Don't post TID_RELEASE message.
The LLD does this for us in cxgb3_remove_tid().
Also fixed active open failure cases where we shouldn't
be releasing the TID as well.
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
drivers/infiniband/hw/cxgb3/iwch_cm.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 4d7c277..228721f 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -254,8 +254,6 @@ static void release_ep_resources(struct
cxgb3_remove_tid(ep->com.tdev, (void *)ep, ep->hwtid);
dst_release(ep->dst);
l2t_release(L2DATA(ep->com.tdev), ep->l2t);
- if (ep->com.tdev->type == T3B)
- release_tid(ep->com.tdev, ep->hwtid, NULL);
put_ep(&ep->com);
}
@@ -1103,6 +1101,15 @@ static int abort_rpl(struct t3cdev *tdev
return CPL_RET_BUF_DONE;
}
+/*
+ * Return whether a failed active open has allocated a TID
+ */
+static inline int act_open_has_tid(int status)
+{
+ return status != CPL_ERR_TCAM_FULL && status != CPL_ERR_CONN_EXIST &&
+ status != CPL_ERR_ARP_MISS;
+}
+
static int act_open_rpl(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
{
struct iwch_ep *ep = ctx;
@@ -1112,7 +1119,7 @@ static int act_open_rpl(struct t3cdev *t
status2errno(rpl->status));
connect_reply_upcall(ep, status2errno(rpl->status));
state_set(&ep->com, DEAD);
- if (ep->com.tdev->type == T3B)
+ if (ep->com.tdev->type == T3B && act_open_has_tid(rpl->status))
release_tid(ep->com.tdev, GET_TID(rpl), NULL);
cxgb3_free_atid(ep->com.tdev, ep->atid);
dst_release(ep->dst);
next prev parent reply other threads:[~2007-06-27 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 15:51 [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23 Steve Wise
2007-06-27 15:51 ` [ofa-general] [PATCH 1/6] iw_cxgb3: Streaming -> RDMA mode transition fixes Steve Wise
2007-06-27 15:51 ` [ofa-general] [PATCH 2/6] iw_cxgb3: TERMINATE WRs can hang the tx ofld queue Steve Wise
2007-06-27 15:51 ` [ofa-general] [PATCH 3/6] iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts Steve Wise
2007-06-27 15:51 ` [ofa-general] [PATCH 4/6] iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit Steve Wise
2007-06-27 15:51 ` Steve Wise [this message]
2007-06-27 15:51 ` [ofa-general] [PATCH 6/6] iw_cxgb3: Don't abort after failures sending the mpa reply Steve Wise
2007-06-27 19:14 ` [ofa-general] Re: [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23 Roland Dreier
2007-06-27 19:31 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627155145.24944.64064.stgit@dell3.ogc.int \
--to=swise@opengridcomputing.com \
--cc=divy@chelsio.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).