From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: "Török Edvin" <edwintorok@gmail.com>,
netdev@vger.kernel.org, power@bughost.org, zambrano@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] b44: power down PHY when interface down
Date: Sat, 30 Jun 2007 16:19:23 +0100 [thread overview]
Message-ID: <20070630151923.GA22983@srcf.ucam.org> (raw)
In-Reply-To: <46866C6B.9010801@linux.intel.com>
On Sat, Jun 30, 2007 at 07:44:59AM -0700, Arjan van de Ven wrote:
> Matthew Garrett wrote:
> >Do you still get link beat detection when the phy is powered down?
> >
> does that matter?
> If the interface is down, nic drivers aren't expected to detect
> link... if userspace wants to find link status it should have the
> interface up.
If that's the policy, why do we leave this up to individual drivers?
Right now most of them let you make the query regardless of interface
state.
I'd agree that there's a need for a state where we power down as much as
possible (even at the cost of functionality), but where possible it
would also be nice to offer a state where the mac is powered down and
the phy left up. If the existing semantics are confused then it would be
nice to fix them, too.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-06-30 15:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 11:47 [PATCH] b44: power down PHY when interface down Török Edvin
2007-06-30 12:05 ` Matthew Garrett
2007-06-30 14:44 ` Arjan van de Ven
2007-06-30 15:19 ` Matthew Garrett [this message]
2007-06-30 15:25 ` Lennert Buytenhek
2007-07-01 13:02 ` Török Edvin
2007-06-30 16:42 ` PM policy, hotplug, power saving (was Re: [PATCH] b44: power down PHY when interface down) Jeff Garzik
2007-06-30 18:10 ` Stephen Hemminger
2007-06-30 18:31 ` PM policy, hotplug, power saving and WoL Henrique de Moraes Holschuh
2007-07-01 4:51 ` PM policy, hotplug, power saving (was Re: [PATCH] b44: power down PHY when interface down) Kyle Moffett
[not found] ` <4354d3270706300447ladcda4by987b1f87963112f9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-30 12:13 ` [PATCH] b44: power down PHY when interface down Stephen Hemminger
2007-07-01 12:49 ` Török Edvin
2007-07-01 12:55 ` Michael Buesch
2007-06-30 21:53 ` Michael Buesch
2007-06-30 22:03 ` Lennert Buytenhek
2007-06-30 22:24 ` Michael Buesch
2007-06-30 23:17 ` Lennert Buytenhek
2007-07-01 10:23 ` Michael Buesch
2007-07-01 15:00 ` Lennert Buytenhek
2007-07-01 15:29 ` Michael Buesch
2007-07-01 20:20 ` Michael Buesch
-- strict thread matches above, loose matches on Subject: below --
2007-07-01 13:25 Török Edvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070630151923.GA22983@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=arjan@linux.intel.com \
--cc=edwintorok@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=power@bughost.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).