From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [2.6 patch] drivers/net/ns83820.c: fix a check-after-use Date: Sun, 1 Jul 2007 22:21:10 +0200 Message-ID: <20070701202110.GH10869@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jgarzik@pobox.com Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:46830 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758674AbXGAUUn (ORCPT ); Sun, 1 Jul 2007 16:20:43 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- --- linux-2.6.22-rc6-mm1/drivers/net/ns83820.c.old 2007-06-29 22:12:22.000000000 +0200 +++ linux-2.6.22-rc6-mm1/drivers/net/ns83820.c 2007-06-29 22:13:59.000000000 +0200 @@ -1985,11 +1985,13 @@ static int __devinit ns83820_init_one(st ndev = alloc_etherdev(sizeof(struct ns83820)); dev = PRIV(ndev); - dev->ndev = ndev; + err = -ENOMEM; if (!dev) goto out; + dev->ndev = ndev; + spin_lock_init(&dev->rx_info.lock); spin_lock_init(&dev->tx_lock); spin_lock_init(&dev->misc_lock);