From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out
Date: Mon, 02 Jul 2007 22:02:27 -0700 (PDT) [thread overview]
Message-ID: <20070702.220227.15591645.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0705311846390.14736@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 31 May 2007 19:31:21 +0300 (EEST)
> (i.e, how does it show up in oops if tcp_verify_left_out looks like this):
>
> #define tcp_verify_left_out(tp) BUG_ON(...)
>
> ...does it still point to the tcp.h line xxxx then or to the
> tcp_sync_left_out(tp) @ line yyyy in tcp_input.c? ...I'll test that
> later on by myself in case you don't know the answer.
Yes a define would make the BUG appear in the function it gets
used in.
Depending upon the configuration and the implementation of BUG()
the same might happen for inline functions too. For example, if
the BUG() is configured in non-verbose mode and is implemented using
a trap instruction or __builtin_trap(). But you cannot depend
upon this universally of course.
next prev parent reply other threads:[~2007-07-03 5:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 8:35 [PATCH 0/9]: tcp-2.6 patchset Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h & remove it Ilpo Järvinen
2007-05-26 8:35 ` [PATCH 6/9] [TCP]: Reorganize lost marking code Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue Ilpo Järvinen
2007-05-26 8:36 ` [PATCH 9/9] [RFC] [TCP]: Kill tp->fackets_out (tcp_sock diet program) Ilpo Järvinen
2007-07-03 5:00 ` [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue David Miller
2007-07-03 11:08 ` Ilpo Järvinen
2007-05-31 8:44 ` [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq David Miller
2007-05-27 7:38 ` [PATCH 6/9] [TCP]: Reorganize lost marking code Ilpo Järvinen
2007-05-31 8:44 ` David Miller
2007-05-31 8:43 ` [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h & remove it David Miller
2007-05-31 8:43 ` [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint David Miller
2007-05-31 8:42 ` [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out David Miller
2007-05-31 16:31 ` Ilpo Järvinen
2007-07-03 5:02 ` David Miller [this message]
2007-05-31 8:40 ` [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting David Miller
2007-05-31 8:39 ` [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier David Miller
2007-05-26 23:44 ` [PATCH 0/9]: tcp-2.6 patchset David Miller
2007-05-27 7:58 ` Ilpo Järvinen
2007-05-27 9:11 ` David Miller
2007-05-27 11:16 ` Ilpo Järvinen
2007-05-27 14:04 ` Baruch Even
2007-05-27 16:56 ` Ilpo Järvinen
2007-05-28 10:27 ` Ilpo Järvinen
2007-05-29 16:14 ` Stephen Hemminger
2007-05-29 20:07 ` Ilpo Järvinen
2007-05-29 20:19 ` Stephen Hemminger
2007-05-29 20:58 ` Ilpo Järvinen
2007-05-29 21:15 ` Stephen Hemminger
2007-05-30 9:10 ` [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) Ilpo Järvinen
2007-06-01 4:38 ` David Miller
2007-06-01 11:22 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070702.220227.15591645.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).