From: Oleg Nesterov <oleg@tv-sign.ru>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module
Date: Mon, 2 Jul 2007 12:59:49 +0400 [thread overview]
Message-ID: <20070702085949.GA110@tv-sign.ru> (raw)
In-Reply-To: <20070702075226.GB1639@ff.dom.local>
On 07/02, Jarek Poplawski wrote:
>
> diff -Nurp 2.6.22-rc7-/net/core/netpoll.c 2.6.22-rc7/net/core/netpoll.c
> --- 2.6.22-rc7-/net/core/netpoll.c 2007-07-02 09:03:27.000000000 +0200
> +++ 2.6.22-rc7/net/core/netpoll.c 2007-07-02 09:32:34.000000000 +0200
> @@ -72,8 +72,7 @@ static void queue_process(struct work_st
> netif_tx_unlock(dev);
> local_irq_restore(flags);
>
> - if (atomic_read(&npinfo->refcnt))
> - schedule_delayed_work(&npinfo->tx_work, HZ/10);
> + schedule_delayed_work(&npinfo->tx_work, HZ/10);
> return;
> }
> netif_tx_unlock(dev);
> @@ -786,7 +785,7 @@ void netpoll_cleanup(struct netpoll *np)
> if (atomic_dec_and_test(&npinfo->refcnt)) {
> skb_queue_purge(&npinfo->arp_tx);
> skb_queue_purge(&npinfo->txq);
> - cancel_delayed_work(&npinfo->tx_work);
> + cancel_rearming_delayed_work(&npinfo->tx_work);
> flush_scheduled_work();
While you are here, could you also delete this flush_scheduled_work() ?
It is not needed any longer.
Oleg.
next prev parent reply other threads:[~2007-07-02 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070701173558.GA207@tv-sign.ru>
2007-07-02 6:34 ` [NETPOLL] netconsole: fix soft lockup when removing module Jarek Poplawski
2007-07-02 9:24 ` Oleg Nesterov
2007-07-02 11:08 ` Jarek Poplawski
2007-07-02 7:52 ` [PATCH] " Jarek Poplawski
2007-07-02 8:59 ` Oleg Nesterov [this message]
2007-07-02 10:12 ` [PATCH 2/2][NETPOLL] netconsole: delete flush_scheduled_work Jarek Poplawski
2007-07-04 6:41 ` [PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module Jarek Poplawski
2007-07-04 6:47 ` David Miller
2007-07-04 7:08 ` Jarek Poplawski
2007-07-04 7:21 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070702085949.GA110@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).